@EyeCantCU It also looks like all of the packages could use an update now that I got to look at all

@EyeCantCU It also looks like all of the packages could use an update now that I got to look at all of the versions https://gitlab.com/asus-linux/supergfxctl/-/releases https://gitlab.com/Jhyub/supergfxctl-plasmoid/-/releases

GitLab

Releases · asus-linux / supergfxctl · GitLab

GitLab.com

GitLab

Releases · Janghyub Seo / supergfxctl-plasmoid · GitLab

GitLab.com

jstoneOP•12/8/23, 3:12 PM

The Gnome extension is probably the most noticeable though because of broken Gnome 45 compatibility

Jjstone @EyeCantCU It also looks like all of the packages could use an update now that I...

EyeCantCU•12/8/23, 4:32 PM

Will get here momentarily

jstoneOP•12/8/23, 4:32 PM

Thank you

bsherman•12/8/23, 4:34 PM

@EyeCantCU it looks like 19 hours ago you merged some ASUS specific stuff into ublue-os/main ?

Bbsherman @EyeCantCU it looks like 19 hours ago you merged some ASUS specific stuff into u...

EyeCantCU•12/8/23, 4:35 PM

Wait what

bsherman•12/8/23, 4:35 PM

i'm not quite sure how... i don't see PRs approved

EEyeCantCU Wait what

bsherman•12/8/23, 4:35 PM

https://github.com/ublue-os/nvidia/commit/76dcb1fa1fb73374d661dee1663506f3d6f65f6f

EyeCantCU•12/8/23, 4:35 PM

I don't recall doing that

EyeCantCU•12/8/23, 4:36 PM

I'll fix that as well?

bsherman•12/8/23, 4:36 PM

and then some surface changes:

https://github.com/ublue-os/nvidia/commit/de17bdd54df22122adad18b414921ea0238f56de

EyeCantCU•12/8/23, 4:36 PM

Great

EyeCantCU•12/8/23, 4:37 PM

I feel like a dumbass

akdev•12/8/23, 4:37 PM

Is main not protected?

bsherman•12/8/23, 4:37 PM

i can revert that stuff no problem, i just wonder how it happened... if it's just an accident, no problem... but was it some automation?

EyeCantCU•12/8/23, 4:37 PM

I don't understand how opening an MR into ASUS/Surface NVIDIA would impact main

EyeCantCU•12/8/23, 4:38 PM

At all.

akdev•12/8/23, 4:38 PM

It is protected

EEyeCantCU I don't understand how opening an MR into ASUS/Surface NVIDIA would impact main

bsherman•12/8/23, 4:38 PM

to me, it looks like the change was merged locally and pushed

EyeCantCU•12/8/23, 4:38 PM

I didn't do that

Aakdev It is protected

bsherman•12/8/23, 4:38 PM

it is protected... but... i think we allow bypassing of rules by those with perms

EyeCantCU•12/8/23, 4:38 PM

Not dumb enough to merge BOTH repos into NVIDIA and force push

EEyeCantCU Not dumb enough to merge BOTH repos into NVIDIA and force push

bsherman•12/8/23, 4:39 PM

i'm not quite sure how it happened either, that's why I'm bringing it up

EyeCantCU•12/8/23, 4:39 PM

I did this via GitHub last night so maybe I overlooked something there?

EyeCantCU•12/8/23, 4:39 PM

Very confused

Bbsherman it is protected... but... i think we allow bypassing of rules by those with perm...

akdev•12/8/23, 4:39 PM

Yeah but you still need to force push I believe

Aakdev Yeah but you still need to force push I believe

bsherman•12/8/23, 4:39 PM

i agree, i think that's required

EyeCantCU•12/8/23, 4:40 PM

The PRs never even existed for NVIDIA which makes zero sense

EEyeCantCU The PRs never even existed for NVIDIA which makes zero sense

bsherman•12/8/23, 4:40 PM

yep, exactly why i was extra confused

EyeCantCU•12/8/23, 4:41 PM

Like how would both repos get changed from one PR?

bsherman•12/8/23, 4:41 PM

honestly, i'm a little nervous about the pull app

EyeCantCU•12/8/23, 4:42 PM

Shouldn't the pull app only work one way?

bsherman•12/8/23, 4:42 PM

yes, but i had weird behavior and ended up almost pushing stuff to the wrong repo after adding it

bsherman•12/8/23, 4:43 PM

i would like to resolve this by force pushing ublue-os/nvidiaublue-os/nvidia such that those last 3 commits never existed

EyeCantCU•12/8/23, 4:44 PM

I agree

EyeCantCU•12/8/23, 4:44 PM

Apologies for everyone. Really screwed up there

EyeCantCU•12/8/23, 4:44 PM

I hadn't even noticed

bsherman•12/8/23, 4:44 PM

I only noticed due to build failures... and then i was surprised because it was obvious we didn't have PRs for those commits

EyeCantCU•12/8/23, 4:45 PM

Maybe GitHub tried to merge both repositories when the PR was opened?

Bbsherman i would like to resolve this by force pushing `ublue-os/nvidia` such that those ...

bsherman•12/8/23, 4:45 PM

@EyeCantCU @akdev

I'll do this now

EyeCantCU•12/8/23, 4:45 PM

Thank you so much

akdev•12/8/23, 4:45 PM

Sounds good to me, thanks for fixing it

jstoneOP•12/8/23, 4:46 PM

This sounds related to when I requested somebody with the right permissions to sync the asus-nvidia repo, which looks like a fork of the nvidia repo. I wonder what happened there. Did github try to be "smart" by automatically applying merges to the fork and the upstream?

EyeCantCU•12/8/23, 4:47 PM

I honestly have no idea but that's definitely not smart behavior lol

bsherman•12/8/23, 4:47 PM

is that request above?

jstoneOP•12/8/23, 4:48 PM

💾ublue-dev

bsherman•12/8/23, 4:48 PM

ok, i read it

bsherman•12/8/23, 4:48 PM

SEEMS simple...

Jjstone This sounds related to when I requested somebody with the right permissions to s...

bsherman•12/8/23, 4:50 PM

thanks for calling out the correlation.

jstoneOP•12/8/23, 4:50 PM

The changes seem reasonable in asus-nvidia

jstoneOP•12/8/23, 4:50 PM

I only detected the drivers being updated

@EyeCantCU It also looks like all of the packages could use an update now that I got to look at all

Similar Threads

Similar Threads

Similar Threads