The docs change is to say to keep SELinux enabled. Currently it says to disable it
The docs change is to say to keep SELinux enabled. Currently it says to disable it
RMy PR removed that text
Joh we just don't mention it
Jso I'll close the PR
JRYeah, that was a bad idea from the start
F@Robert (p5) you forgot to update this part of README
F
DI might need some help understanding this. The argument for NVIDIA_FLAVOR is making it to the buildah command.
buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 --label io.artifacthub.package.readme-url=https://raw.githubusercontent.com/ublue-os/akmods/main/README.md --label org.opencontainers.image.created=2024-08-08T15:37:49.669Z --label org.opencontainers.image.description=A caching layer for pre-built akmod RPMs --label org.opencontainers.image.licenses=Apache-2.0 --label org.opencontainers.image.revision=4bf4904792d88ddce5d03dbf59540e78fd4b7623 --label org.opencontainers.image.source=https://github.com/ublue-os/akmods --label org.opencontainers.image.title=akmods --label org.opencontainers.image.url=https://github.com/ublue-os/akmods --label org.opencontainers.image.version=6.9.12-200.fc40.x86_64.20240808.0 --label ostree.linux=6.9.12-200.fc40.x86_64 --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40 /home/runner/work/akmods/akmods
But in the container file even with ARG NVIDIA_FLAVOR, I am seeing it unset.
buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 --label io.artifacthub.package.readme-url=https://raw.githubusercontent.com/ublue-os/akmods/main/README.md --label org.opencontainers.image.created=2024-08-08T15:37:49.669Z --label org.opencontainers.image.description=A caching layer for pre-built akmod RPMs --label org.opencontainers.image.licenses=Apache-2.0 --label org.opencontainers.image.revision=4bf4904792d88ddce5d03dbf59540e78fd4b7623 --label org.opencontainers.image.source=https://github.com/ublue-os/akmods --label org.opencontainers.image.title=akmods --label org.opencontainers.image.url=https://github.com/ublue-os/akmods --label org.opencontainers.image.version=6.9.12-200.fc40.x86_64.20240808.0 --label ostree.linux=6.9.12-200.fc40.x86_64 --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40 /home/runner/work/akmods/akmods
But in the container file even with ARG NVIDIA_FLAVOR, I am seeing it unset.
DI did
ARG NVIDIA_FLAVOR
ENV NVIDIA_FLAVOR=${NVIDIA_FLAVOR}
RUN DRIVER_TYPE=$([ "$NVIDIA_FLAVOR" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE
and it shows nf - dt kernel-open
ARG NVIDIA_FLAVOR
ENV NVIDIA_FLAVOR=${NVIDIA_FLAVOR}
RUN DRIVER_TYPE=$([ "$NVIDIA_FLAVOR" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE
and it shows nf - dt kernel-open
Denv shows NVIDIA_FLAVOR=
DAm I fundamentally misunderstanding how build arguments should work on a containerfile?
DI do see --build-arg NVIDIA_FLAVOR=nvidia-legacy in the initial command
RAh, thanks. I'll do another README cleanup PR in a bit.
DI wonder if this is a bug in buildah
D... wow. I removed the labels and it worked. I think something in the github action to parse labels to command line args is breaking it
D❯ buildah bud -f Containerfile.nvidia --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40
...
[2/3] STEP 16/18: ARG NVIDIA_FLAVOR
[2/3] STEP 17/18: RUN DRIVER_TYPE=$([ "${NVIDIA_FLAVOR}" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE
nf nvidia-legacy - dt kernel
...
[2/3] STEP 16/18: ARG NVIDIA_FLAVOR
[2/3] STEP 17/18: RUN DRIVER_TYPE=$([ "${NVIDIA_FLAVOR}" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE
nf nvidia-legacy - dt kernel
Dor maybe it's a formatting issue w/ one of the labels breaking it. Maybe I'll try re-adding labels one at a time.
N@j0rge Bluefin got a shout-out from Dan Walsh on the big screen.
J\o/
Jwhat room are you in? I'll go find it
NRed Hat room, you'll have to back up a few minutes!
Jk
Dthat's awesome
NI was not expecting it lol
Joh this whole talk looks good, backing up
NYes! I recommend everyone watch this talk.
NIt's really well presented.
NDan Walsh is a legend.
DWorking:
buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url='https://avatars.githubusercontent.com/u/1728152?s=200&v=4' --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40
Not working:
buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40
Might have to put values in quotes.
buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url='https://avatars.githubusercontent.com/u/1728152?s=200&v=4' --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40
Not working:
buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40
Might have to put values in quotes.
Jwhen he says "we want you to do more stuff day 0"
Jliterally the same shit I'm putting in the docs
Ause tripple ampersand plz
Dtriple ampersand is an escape?
KI don't think we can merge this @Dylan
Kwould break existing images
AKthey look for
-nvidiaKnot
-nvidia-legacy or -nvidia-openKwould require everyone that consumes akmods to update their pulls
Abelow escape
Awith shift
DI can change it from -nvidia-legacy to -nvidia
Kthat would be good
DI do need some help though with figuring out why the labels are making my arg not pass in
DI'm kind of stuck on that one last bit
J
J@Noel tell him this slide matches our website, nearly bullet for bullet too.
DI updated it
JOMG
Jthey're doing zstd:chunked because some of the RHEL AI images are freaking 50-100GB, LOL
