Distant Horizons•2mo ago

Consistent Shader Compile Errors

Using the latest DH release 2.3.3-b Complementary and Photon creates compile errors. If switched to BSL which doesn't encounter them, and then back to the ones which encountered them prior it works again. I suspect that the DISTANT_HORIZONS is for some reason not set property as both photon and Comp declare DH uniforms under that define

latest.log

Solution:

Can confirm it's fixed on 1.21.7 neoforge thanks to https://gitlab.com/distant-horizons-team/distant-horizons/-/commit/1e636072334098c748b6df43cf572ed370a65c22

GitLab

Fix AfterDhInitEvent not firing on Neo (1e636072) · Commits · Dis...

Fixes some Iris shader compile issues

Jump to solution

62 Replies

Allium•2mo ago

latest.log uploaded to mclo.gs

Uploaded by spaceagle17

SpacEagle17OP•2mo ago

To reproduce: launch the game and select Complementary or Photon Multiple users confirmed this as well in my server and in the Photon one, that is why I came here :)

SpacEagle17OP•2mo ago

SpacEagle17OP•2mo ago

So yeah I think that shows that it's something consistent Reminder that Complementary has those only under the DISTANT_HORIZONS define declared

Skillnoob_•2mo ago

@SpacEagle17 https://discord.com/channels/881614130614767666/881749094308139008/1394661189996249179

SpacEagle17OP•2mo ago

Ty will try when back home :) I do hope this also fixes shader compile errors as that I believe to be a different error to the visual issues Photon as well, and both of these had compile issues leading me to think that the said define was just undefined

SpacEagle17OP•2mo ago

Doesn't look like it Will later try it out myself and if not comment on the gitlab issue as it doesn't seem that issues here in discord are looked at as often

Skillnoob_•2mo ago

latest nightly doesn't seem to resolve the issue for me

SpacEagle17OP•2mo ago

Nope it does not. I commented on the issue tracker https://gitlab.com/distant-horizons-team/distant-horizons/-/issues/1087#note_2629070970

GitLab

Version 2.33-b cannot use the Shaders (#1087) · Issues · Distant-...

2.33-b，mc1.20.1，Oculus1.8

SpacEagle17OP•2mo ago

If it's not the DISTANT_HORIZONS then I am out of ideas as everything point to that just being undefined This is from iris source code to define said define

if (IrisPlatformHelpers.getInstance().isModLoaded("distanthorizons") && DHCompat.hasRenderingEnabled()) {
  (standardDefines, "DISTANT_HORIZONS");
}

if (IrisPlatformHelpers.getInstance().isModLoaded("distanthorizons") && DHCompat.hasRenderingEnabled()) {
  (standardDefines, "DISTANT_HORIZONS");
}

Perhaps the hasRenderingEnabled() part broke on DH end and iris does not read it correctly anymore? No clue how the API works, just guesses. I doubt it would be the first part.

BackSun•2mo ago

Does the issue only occur with Oculus? Iris works properly for me.

SpacEagle17OP•2mo ago

My test was with iris for 1.21.7 on neoforge Will try rn with the nightly myself

乃𝘢𝘸𝘭乙•2mo ago

I'm experiencing the same issue on 1.21.1 with Neo .192 / Iris 1.8.12 -- the nightly did not fix the issue. 2.3.2 works, also up to (sorry can't remember which build, early June?) a certain nightly of 2.3.3 was fine

SpacEagle17OP•2mo ago

Can reproduce with DistantHorizons-neoforge-2.3.4-b-dev-1.21.7 on neoforge and Complementary r5.5.1 and latest release of Photon

SpacEagle17OP•2mo ago

As I already mentioned both use the DISTANT_HORIZONS define This is Complementary

SpacEagle17OP•2mo ago

This is photon - it also puts samplers and so on under the define

SpacEagle17OP•2mo ago

No issues on fabric 1.21.7 with the nightly Only on neoforge

Skillnoob_•2mo ago

I was using iris as well to do the testing, no oculus

BackSun•2mo ago

If y’all can find which nightly build broke it that help me fix the problem.

SpacEagle17OP•2mo ago

NightlyBuild_1.21.7-1edd8097-2025-07-11T07_29_46-05_00.zip still works so it is a rather recent issue Seems to have broken in NightlyBuild_1.21.7-2bc5169c-2025-07-12T08_02_08-05_00.zip unless I missed one

SpacEagle17OP•2mo ago

If I did not accidentally skip over a nightly it should be this

SpacEagle17OP•2mo ago

@James Seibel GMT-5 :)

BackSun•2mo ago

Weird. Thanks for finding that, can you share which versions of Neo, Iris, sodium, and the shader you used that had the problem?

SpacEagle17OP•2mo ago

Ofc DId rn a fresh instance for testing

iris-neoforge-1.9.1+mc1.21.7.jar
sodium-neoforge-0.6.13+mc1.21.6.jar
DistantHorizons-neoforge-2.3.3-b-dev-1.21.7.jar <- broken one
Neoforge: 21.7.23-beta
Shaders: Complementary Reimagined r5.5.1, Photon v1.2a <- both break, both work fine in the nightly before: NightlyBuild_1.21.7-1edd8097-2025-07-11T07_29_46-05_00

iris-neoforge-1.9.1+mc1.21.7.jar
sodium-neoforge-0.6.13+mc1.21.6.jar
DistantHorizons-neoforge-2.3.3-b-dev-1.21.7.jar <- broken one
Neoforge: 21.7.23-beta
Shaders: Complementary Reimagined r5.5.1, Photon v1.2a <- both break, both work fine in the nightly before: NightlyBuild_1.21.7-1edd8097-2025-07-11T07_29_46-05_00

Skillnoob_•2mo ago

yup, breaks for me right on the same commit https://gitlab.com/distant-horizons-team/distant-horizons/-/commit/2bc5169ce51e1b858ece0bcbc88a96ed2d070257

GitLab

Closes #1084 (AfterDhInitEvent firing before DH config setup) (2bc5...

This is a mod that adds a Level Of Detail (LOD) system to Minecraft. This implementation renders simplified chunks outside of the normal render distance allowing for an...

SpacEagle17OP•2mo ago

My guess is still on the DH define not being defined XD Not sure why that commit would make it not work but I assume DHCompat.hasRenderingEnabled() this part in iris no longer is true after that commit That is if it's actually the DH define and not something completely random

Skillnoob_•2mo ago

for 1.21.1 i was using (all on the latest): Neoforge: 21.1.192 Sodium: 0.6.13+mc1.21.1 Iris: 1.8.12-snapshot+mc1.21.1-local

乃𝘢𝘸𝘭乙•2mo ago

^ Same. That's the commit that broke it

SpacEagle17OP•2mo ago

Glad that's confirmed :)

Skillnoob_•2mo ago

From what I can tell iris uses the DhApiAfterDhInitEvent that got moved in the commit, so i guess something is breaking there? https://github.com/IrisShaders/Iris/blob/b4b2c22c1587264989d746ae57423c32cf6dfcb4/common/src/main/java/net/irisshaders/iris/compat/dh/LodRendererEvents.java#L52

SpacEagle17OP•2mo ago

Why does it work on fabric just fine tho? That's the odd thing

Skillnoob_•2mo ago

I think postInit() is not being called on neoforge, the Post-Initializing Mod log message does not appear in the neoforge log, while it does on fabric https://gitlab.com/distant-horizons-team/distant-horizons/-/blob/main/common/src/main/java/com/seibel/distanthorizons/common/AbstractModInitializer.java#L182 Before that commit the event was called twice in onInitializeClient() and onInitializeServer() @James Seibel GMT-5 @SpacEagle17 does Post-Initializing Mod appear in your logs?

SpacEagle17OP•2mo ago

Can check in a bit

BackSun•2mo ago

Huh, interesting. Well that should be pretty easy to test, thanks!

乃𝘢𝘸𝘭乙•2mo ago

it's never reaching the delayed setup for me

Skillnoob_•2mo ago

This isn't being called i think https://gitlab.com/distant-horizons-team/distant-horizons/-/blob/main/common/src/main/java/com/seibel/distanthorizons/common/AbstractModInitializer.java#L112 and some people on forge don't have the dh command, at least there were issues about that https://discord.com/channels/881614130614767666/1382587321899155578 https://discord.com/channels/881614130614767666/1369897754264076339

SpacEagle17OP•2mo ago

Nope Tested on Neoforge 1.21.7

Skillnoob_•2mo ago

then its basically what i guessed, the postinit isn't being called which causes iris to never see the event and not initialize relevant stuff

SpacEagle17OP•2mo ago

Yep makes sense. Any clue why it works on fabric and not neo?

Skillnoob_•2mo ago

DH needs a mod initializer for each mod loader and this is the abstract mod initalizer which abstracts away most of the things needed for that And I guess some event on the forge side isn't being called

SpacEagle17OP•2mo ago

Makes sense and sounds so nice to have a monojar like that XD I gotta switch between branches whenever I do a change and copy paste that into the other branches myself for each mod loader I support lol

Skillnoob_•2mo ago

which is somewhere in here: https://gitlab.com/distant-horizons-team/distant-horizons/-/blob/main/neoforge/src/main/java/com/seibel/distanthorizons/neoforge/NeoforgeMain.java Did anyone test if the same issue happens on forge 1.20.1 with oculus/embeddium as well? I can't test that rn since I'm reinstalling my OS

SpacEagle17OP•2mo ago

Also can't test rn and nope I didn't

Skillnoob_•2mo ago

I tried before but forge refused to launch for some reason lol

Skillnoob_•2mo ago

https://gitlab.com/distant-horizons-team/distant-horizons/-/merge_requests/81

GitLab

Fixed Forge not firing AfterInit API Event on clients (Closes #1095...

This is a mod that adds a Level Of Detail (LOD) system to Minecraft. This implementation renders simplified chunks outside of the normal render distance allowing for an...

乃𝘢𝘸𝘭乙•2mo ago

it's broken for me on 1.20.1 with forge / oculus / embeddium.

Unknown User•2mo ago

Message Not Public

м'юн•2mo ago

broken on 1.21.1 with neoforge/iris even with the latest nightly build:pookiessadshake:

BackSun•2mo ago

Well luckily for you that's because the nightly build that fixes the problem hasn't finished compiling yet. Give it another 40 minutes then try again.

м'юн•2mo ago

ohh, I see, thanks a lot :pookieshihi:

乃𝘢𝘸𝘭乙•2mo ago