MY RENDERER's circle rendering code is...complicated
MY RENDERER's circle rendering code is...complicated
Dbecause it's a port (with permission) of someone else'ss circle rendering code that was written for monogame
DAnd I do NOT understand the mental witchcraft that thing does so like
DI just
Ddon't touch it
Dit crashes the engine sometimes
DI need better circle rendering code
Dthis is the colossal mess that is that circle code
Dmessage.txt5.32KB
DI had to hack in texture support
Dso I can render profile pictures in my game with rounding, because non-rounded profile pictures are a relic of the feckin 1400s
Dpart of the issue is
maxError defaults to an insanely low value, butDthe engine crashes more often the higher that value is defaulted to
Dthis is where it crashes
D
Qcan I see your circle rendering code? Probably just beziers I believe
Dsee above
DI posted it
Qcan't find it. The
FillCircle methods just call other fill circle methods.Qor I don't understand it - which is more likely
DDiscord trims the file down on my end
Dtry downloading it
DOh it's an unbound stack alloc!
DI accidentally pasted a stupidly long text rendering function in with it, my bad
DThat's a good idea 
DLikely that's what the crashes are from
DCrashing's from an index range exception
DOh ok what
DIf you want I can take a closer look at my PC later
DWorkaround is to round the radius of the circle before computing the error value
Ti think i have an enumerator struct somewhere that enumerates points of a circle edge
DIt's pretty simple to calculate n numbers laying on a circle equally spaced apart
Toh even better, it's an EllipseEnumerable
DOnce I started rounding the radius to the nearest whole number, I could safely set the error much higher without the engine ever crashing
Dand now I went from 100 FPS when there's a circle on screen to uh
D2000
TDwhat's wrong with stackalloc though
Twe don't have unlimited memory + it's usually cleared if you dont have [SkipLocalsInit]
Dno stackalloc is great
Dbut if you have it unbound, like in your case
Dit can happen that you allocate 10000 bytes on the stack
Talthough i doubt clearing is slower than a slightly branching enumerator
Dand that will throw StackOverflow, which is uncatchable and effectively terminates your app
Dyeahhh I've gotten StackOverflow with significantly low maxError values
Tthe limit is way more than 10kB but yeah, you have to control it somehow
Tconsidering that there's usually 2MB of stack, i think you got way too many points there :)
DYeahhhhhhhhhhhhhhhhh
Dalso why are you passing a Span<Vector2> by
refEllipses are definitely something thundershock needs too
DOr rather, a way to draw a circle that's basically just uh
