ok the c# spec does not outline it. although it has been discussed on the c# server before it was a

ok the c# spec does not outline it. although it has been discussed on the c# server before
it was a "all runtimes do it so it's basically safe to rely on it"

TTechPizza ok the c# spec does not outline it. although it has been discussed on the c# ser...

Alexx999•4/19/22, 1:54 PM

yup, pretty much that's that

Alexx999•4/19/22, 1:55 PM

but that's implementation detail, probably added in order to speed up Win32 calls

Alexx999•4/19/22, 2:00 PM

matter-of-factly, you can't even check if C# string has a null terminator or not from safe context

TechPizzaOP•4/19/22, 2:01 PM

ref arithmetic wants to know your location

Alexx999•4/19/22, 2:01 PM

so some safe-only runtimes may have non-null-terminated strings just fine and no one would ever know

TechPizzaOP•4/19/22, 2:02 PM

hold on. do safe-only runtimes even exist?

TTechPizza hold on. do safe-only runtimes even exist?

Alexx999•4/19/22, 2:02 PM

yeah, if you're old enough to remember Windows Phone and Silverlight and WinRT and company

Alexx999•4/19/22, 2:03 PM

I coded on Windows Phone 7 back in a day, that was quite a performance shitshow with all the limitations

TechPizzaOP•4/19/22, 2:12 PM

so it was basically microsoft java, got it

TTechPizza so it was basically microsoft java, got it

Alexx999•4/19/22, 2:30 PM

pretty much, yes

Alexx999•4/19/22, 2:32 PM

oh, also, no emit
and mostly no reflection in general
probably something else too...

KKai in fact, depending on roslyn codegen, it may even be null terminated three times

Supine•4/19/22, 5:03 PM

Is that so called

ILStub

ILStub

Encoding.UTF8.GetByteCount

Encoding.UTF8.GetByteCount

eww

Kai•4/19/22, 5:04 PM

That is the official P/Invoke stubs yes

SSupine Is that so called `ILStub`? `Encoding.UTF8.GetByteCount` eww

Alexx999•4/19/22, 6:07 PM

and what's wrong with GetByteCount?

AAlexx999 and what's wrong with GetByteCount?

Supine•4/19/22, 6:08 PM

It actually does conversion behind the scenes (afaik)

SSupine It actually does conversion behind the scenes (afaik)

Alexx999•4/19/22, 6:09 PM

that's normal C++ish pattern for doing stuff when memory is caller-allocated

Alexx999•4/19/22, 6:10 PM

you do a dry run to figure out the memory requirements, allocate memory and then do actual run with allocated memory

AAlexx999 you do a dry run to figure out the memory requirements, allocate memory and then...

Supine•4/19/22, 6:10 PM

I allocate

(len+1)*3+1

(len+1)*3+1

bytes

Supine•4/19/22, 6:11 PM

And then encode utf8 data to it

SSupine And then encode utf8 data to it

Alexx999•4/19/22, 6:11 PM

that's because you're not developing any frameworks

Alexx999•4/19/22, 6:11 PM

or runtimes

Alexx999•4/19/22, 6:11 PM

otherwise you'd be rather hated for wasting THAT much memory

Alexx999•4/19/22, 6:12 PM

...or even not running your code in 32bit mode

Supine•4/19/22, 6:12 PM

It actually isn't used here.
I use 1024 bytes of stack memory

Supine•4/19/22, 6:12 PM

Regardless of what i actually need

Supine•4/19/22, 6:13 PM

Cuz performance

Supine•4/19/22, 6:13 PM

(That i never had problems with there)

Supine•4/19/22, 6:16 PM

I have defines for CONSERVATIVE STACK and CONSERVATIVE HEAP btw, they're compiling options

SSupine I allocate `(len+1)*3+1` bytes

Kai•4/19/22, 6:34 PM

I mean that is literally what is done in other places, the P Invoke stubs are generate very well optimized. I'm assuming they have a good reason why the length was required here (feel free to go back and check, can't be bothered rn)

KKai I mean that is literally what is done in other places, the P Invoke stubs are ge...

Alexx999•4/19/22, 6:38 PM

easy: imagine string with 1073741791 characters

Alexx999•4/19/22, 6:39 PM

or even 715827882

Alexx999•4/19/22, 6:40 PM

and before you ask - yeah, I've seen systems operating on such strings

Perksey•4/19/22, 6:41 PM

I mean, all you’d need to do is try to marshal the bee movie script and suddenly your system doesn’t cut it

Alexx999•4/19/22, 6:44 PM

also, memory is not always free, there's cost for having 3x mem usage

Perksey•4/19/22, 7:22 PM

@alexx999_ sorry for the delay, will have a poke around your draft PR now!

PPerksey @alexx999_ sorry for the delay, will have a poke around your draft PR now!

Alexx999•4/19/22, 7:51 PM

btw, I can prove that moving structs is not a breaking change

Kai•4/19/22, 7:51 PM

hate to brag, but 14 lines of change to go from empty struct to struct with full member functionality https://github.com/dotnet/Silk.NET/commit/f948995066801ddd53b0cc9d8363f1ca84c18485
Don't think I've ever managed incremental dev to this degree

Kai•4/19/22, 7:54 PM

Also sleepy brian messing up indent and intend again

Perksey•4/19/22, 7:56 PM

sleepy brian

Lyris the Kitori•4/19/22, 7:57 PM

who

Kai•4/19/22, 7:57 PM

as you can see, I'm sleepy

Kai•4/19/22, 7:57 PM

Hi Sleepy, I'm brian

Lyris the Kitori•4/19/22, 7:57 PM

hi brian, im dead inside

Perksey•4/19/22, 7:59 PM

byeee briann

Alexx999•4/19/22, 8:07 PM

@Perksey namely, struct names doesn't really matter because extensions are broken - you cannot use GetProcAddress for OpenCL
and if you can't use any extensions with Silk then it's not a breaking change to break them

Perksey•4/19/22, 8:08 PM

how are extension functions even loaded then

Perksey•4/19/22, 8:09 PM

that was the best guess i had at the time

Alexx999•4/19/22, 8:10 PM

yeah, that's the funny bit: even the official Khtonos ICD dll (that I'm using) is not exposing cl_khr_icd extension method (clIcdGetPlatformIDsKHR) which is literally the only feature this DLL has

Alexx999•4/19/22, 8:11 PM

so you must enumerate platform objects and then query extensions per platform

Alexx999•4/19/22, 8:12 PM

it's done this way because each platform may reside in separate standalone .dll