I’ll leave some feedback there tonight. This is correct however we’ll need a small bit of transition

I’ll leave some feedback there tonight. This is correct however we’ll need a small bit of transition code to maintain compat. Otherwise existing users are going to get the first run installer again unexpectedly

MMarco (马可)I’ll leave some feedback there tonight. This is correct however we’ll need a sma...

Arcitec•5/15/23, 9:18 PM

I know but didn't consider it mattering, because yafti is only used by people who rolled custom images (Small percentage) and it's all marked as alpha, so having transition code is kinda pointless.

Marco (马可)OP•5/15/23, 9:19 PM

It’s used in bluefin as well

Rosmarus•5/15/23, 9:19 PM

How well does sericea-nvidia work?

MMarco (马可)It’s used in bluefin as well

Arcitec•5/15/23, 9:19 PM

Okay. Do we really want some messy code that looks for the old file and moves it to the new location though? Bluefin is ALSO alpha software. And they'll see yafti.yml every time it updates anyway.

j0rge•5/15/23, 9:20 PM

yeah but it's annoying

AArcitec Okay. Do we really want some messy code that looks for the old file and moves it...

Bigpod•5/15/23, 9:20 PM

last part i dont like

Bigpod•5/15/23, 9:20 PM

i dont want to see it every time it updates

RRosmarus How well does sericea-nvidia work?

dreamyuki•5/15/23, 9:20 PM

It works
But the experience is horrible

j0rge•5/15/23, 9:20 PM

it's like, I can ignore lots of stuff but popups enrage me

RRosmarus How well does sericea-nvidia work?

bsherman•5/15/23, 9:20 PM

at least as good as Sericea + rpmfusion nvidia drivers

I did rebase to it once... It works, but I haven't had the itch to stick with tiling for a while.

j0rge•5/15/23, 9:20 PM

like half the reason I'm doing this is so my computer never bothers me again (with stuff like update windows, etc)

dreamyuki•5/15/23, 9:21 PM

Sway + nvidia = flickering

Jj0rge it's like, I can ignore lots of stuff but popups enrage me

Bigpod•5/15/23, 9:21 PM

same i ignore lots of stuff automagically but open a window without a realy realy good reason === rage, for me

Ddreamyuki Sway + nvidia = flickering

bsherman•5/15/23, 9:21 PM

right, but not unique to rpm-ostree/ublue releases... but at least you can easily test with a rebase of ublue

AArcitec Regarding GParted, I have been back and forth on that too, for my own fork. GNOM...

akdev•5/15/23, 9:21 PM

I'd probably say we should respect fedora upstream tbh

j0rge•5/15/23, 9:22 PM

like at work when the ubuntu machine's update manager pops up ...

j0rge•5/15/23, 9:22 PM

I hate that thing so much

Bigpod•5/15/23, 9:22 PM

in regards to gparted is one of those tools that generally isnt needed by most unless they need to do something specific so its something users can layer themselfs

AArcitec Okay. Do we really want some messy code that looks for the old file and moves it...

Marco (马可)OP•5/15/23, 9:23 PM

I’ll think about it and reply to the PR later tonight

Jj0rge it's like, I can ignore lots of stuff but popups enrage me

Arcitec•5/15/23, 9:23 PM

This is about yafti's new config location. It's only used in custom images and in bluefin. Both are alpha.

Bluefin installations will currently see yafti every time they install the OS and every time yafti.ymlyafti.yml changes (that's how it's designed), i.e. when Bluefin changes default config.

I can certainly put in code that also looks at the old location but yikes that's messy for something that fixes itself after 1 Yafti appearance.

Arcitec•5/15/23, 9:23 PM

For alpha I am never in favor of backwards-compat code unless it's very clean. In this case it's not clean.

Arcitec•5/15/23, 9:23 PM

The config system is very interwoven.

j0rge•5/15/23, 9:24 PM

I'm fine with it needing to happen, I'm just saying hey if you wanna keep adding stuff remember people are using it even though it's alpha

j0rge•5/15/23, 9:24 PM

so more, let's figure out a way to do that part better

j0rge•5/15/23, 9:24 PM

because yeah it's alpha

Arcitec•5/15/23, 9:24 PM

Yeah like I mentioned, I always aim for backwards compat unless the code smell becomes ugly as a result.

Arcitec•5/15/23, 9:24 PM

https://github.com/ublue-os/yafti/pull/102/commits

Arcitec•5/15/23, 9:25 PM

That's the current PR.

Bigpod•5/15/23, 9:25 PM

alpha doesnt mean we can cowboy everything however we want, it means things break

j0rge•5/15/23, 9:25 PM

j0rge•5/15/23, 9:25 PM

it's no kinoite-nvidia but I love that sparkline

BBigpod alpha doesnt mean we can cowboy everything however we want, it means things brea...

Arcitec•5/15/23, 9:25 PM

Nothing breaks, let's not be dramatic.

j0rge•5/15/23, 9:25 PM

it's like pure dopamine

Jj0rge it's like pure dopamine

Arcitec•5/15/23, 9:26 PM

That's a lot of data! I can't wait for deltas for OCI containers.

j0rge•5/15/23, 9:26 PM

bluefin's not even popular

AArcitec Nothing breaks, let's not be dramatic.

Bigpod•5/15/23, 9:26 PM

ok great, but what i said still stands we cant just do whatever we want just because its alpha

j0rge•5/15/23, 9:27 PM

j0rge•5/15/23, 9:27 PM

^^^ kinoite

BBigpod ok great, but what i said still stands we cant just do whatever we want just bec...

Arcitec•5/15/23, 9:27 PM

Yeah I really hope you didn't get that interpretation from what I was saying.

Jj0rge Click to see attachment

Arcitec•5/15/23, 9:28 PM

I can add a hack that moves the old config if detected. With a note that it (the hack) should be removed in a few versions.

Arcitec•5/15/23, 9:29 PM

It's gonna be very ugly though, since the move also involves creating folders, so there'll be some WET here (as opposed to DRY).

Arcitec•5/15/23, 9:29 PM

j0rge•5/15/23, 9:29 PM

yeah put that in the issue/pr, I guarantee marco won't remember anything not in github

Arcitec•5/15/23, 9:30 PM

Put in the hack, you mean?

Arcitec•5/15/23, 9:30 PM

I'll do it now, no problem.

Arcitec•5/15/23, 9:38 PM

@marcoceppi Added backwards compat. Are the TODO:TODO: markers enough of a reminder for the future or do you want a ticket to track the removal?

https://github.com/ublue-os/yafti/pull/102/commits/5bda85cda3caceb6c64df5945c4bd42520873be6

Arcitec•5/15/23, 10:00 PM

Was there a decision on adding gpartedgparted to

main

main

? @akdev voted for "Respect Fedora by not adding it". I voted "I don't know, struggling with the same decision for my own fork".

Arcitec•5/15/23, 10:01 PM

Unfortunately GParted isn't on Flathub. It could probably work since GNOME Disks works there.

j0rge•5/15/23, 10:02 PM

no issue filed yet afaict?

Arcitec•5/15/23, 10:03 PM

Yeah, Odoben asked for it and was gonna make a ticket.

I’ll leave some feedback there tonight. This is correct however we’ll need a small bit of transition

Similar Threads

Similar Threads

Similar Threads