Hello Peter - thanks for pinging again! I responded here: https://github.com/cloudflare/workers-sdk

Hello Peter - thanks for pinging again! I responded here: https://github.com/cloudflare/workers-sdk/pull/3384

It may be next week before a dev can review it, but the team is aware.

MMarty Henderson 👋 Possibly a dumb question - but is there something special that needs to be d...

Hello, I’m Allie!•6/16/23, 3:29 PM

Can you share your code?

AAdam Hello Peter - thanks for pinging again! I responded here: https://github.com/cl...

Peter Belbin•6/16/23, 4:02 PM

Hey Adam, thank you for the progress on that. I'm kinda mystified by something you mentioned in your comment regarding TTL of content in the distributed data centers. If I understand it correctly, you're pointing out that the TTL will be 1 week. But, the TTL I'm concerned about is that for KV assets for the sitesite, specifically the assets that are no longer part of the latest deployed site. Am I correct in thinking they are two different things?

MMarty Henderson @skye_31 one quick q that popped to mind - is there a better way to do this for ...

Hello, I’m Allie!•6/16/23, 6:51 PM

Use R2?

Hasi•6/17/23, 12:53 PM

text: 'Uncaught ReferenceError: document is not defined\n' text: 'Uncaught ReferenceError: document is not defined\n'

Hasi•6/17/23, 12:53 PM

I can't start the default react website.

HHasi I can't start the default react website.

Hello, I’m Allie!•6/17/23, 12:53 PM

A create-react-app?

Hello, I’m Allie!•6/17/23, 12:54 PM

What do you mean, "default"?

HHello, I’m Allie!A create-react-app?

Hasi•6/17/23, 12:54 PM

yep

HHello, I’m Allie!What do you mean, "default"?

Hasi•6/17/23, 12:54 PM

Default: The one created with the cloudflare-create

Hasi•6/17/23, 12:58 PM

soo what's the solution?

Hello, I’m Allie!•6/17/23, 1:03 PM

Huh, that one is kind of borked... Let me see if I can get it working...

HHello, I’m Allie!Huh, that one is kind of borked... Let me see if I can get it working...

Hasi•6/17/23, 1:04 PM

Welp, just deploy a react app

Hello, I’m Allie!•6/17/23, 1:07 PM

Yeah, looks like something the React dev server is returning breaks GZip...

HHello, I’m Allie!Yeah, looks like something the React dev server is returning breaks GZip...

Hasi•6/17/23, 1:08 PM

yep, I see it

Steved•6/18/23, 9:53 PM

I've just created a new svelte project with C3, and run npm run pages:devnpm run pages:dev which in turn runs wrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run devwrangler pages dev --compatibility-date=2023-06-18 --proxy 5173 -- npm run dev. This triggers an oauth login to cloudflare in the browser. Out of interest, why? Given it's running locally with Wranger v3.

kian•6/19/23, 4:21 PM

Local development that uses

workerd

workerd

doesn't support that architecture, correct

kian•6/19/23, 9:27 PM

Pass it to

deploy

deploy

like wrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEYwrangler deploy --var GOVEE_API_KEY:$WRANGLER_GOVEE_API_KEY but those are plain-text in the dashboard & whatnot so ideally you'd use secrets.

kian•6/19/23, 9:27 PM

KV has no CLI arg unfortunately

DaniFoldi•6/19/23, 9:37 PM

wrangler-action also has a secrets: section where you can provide secrets it will upload every time

kian•6/19/23, 9:55 PM

Have you done npm inpm i (or the equivalent in the package manager you're using) in CI already?

kian•6/19/23, 9:58 PM

preCommands: npm installpreCommands: npm install should be all you need I suppose

kian•6/19/23, 9:58 PM

It'll go in the withwith block - put it before commandcommand (just aesthetics)

James•6/19/23, 9:59 PM

I'd heavily encourage using npm cinpm ci over

npm install

npm install

if you have a lockfile, for stable and reproducible builds, but yep, preCommandspreCommands is great for that

James•6/19/23, 10:01 PM

devDependenciesdevDependencies is fine and what I'd recommend for something like this. But it won't matter here

Hello Peter - thanks for pinging again! I responded here: https://github.com/cloudflare/workers-sdk

Similar Threads