are you talking about caching with the new build caching, or the version that ships directly in the

are you talking about caching with the new build caching, or the version that ships directly in the image?

df4f2bc3-acd3-4b5d-8c74-475f3ed2303ddf4f2bc3-acd3-4b5d-8c74-475f3ed2303d 10 minutes to download Node v20.3.1v20.3.1.

JJacob are you talking about caching with the new build caching, or the version that sh...

itsmatteomanf•8/30/23, 7:56 PM

Caching it in the caching of the dependencies, since it exists now. Either proxy the node files with some caching (or even R2), or put it in the deps cache.

JacobOP•8/30/23, 7:57 PM

We may do that in the future, but tool caching is out of scope for the current sprint. I'll raise this with the team - 10 minutes is a long time

itsmatteomanf•8/30/23, 7:58 PM

Gotcha, hopefully it's resolved soon, I have seen it fail altogether, but less so lately since the changes in node's infra.

James•8/31/23, 10:28 AM

I'm not really seeing that much of a difference in build times with caching personally. It's taking the same amount of time to restore the dependencies from the cache as it was to download the depedencies with pnpm.

itsmatteomanf•8/31/23, 11:05 AM

Yeah, same here but my lists are small, so can’t really conclude much…

JacobOP•8/31/23, 3:55 PM

I think the speedups will probably be most visible in projects that have long build times. A demo Gatsby project with a lot of files and image resizing went from 4.5 min builds to <2.

We’re deff going to try to make dep caching faster, though.

JJacob I think the speedups will probably be most visible in projects that have long bu...

itsmatteomanf•8/31/23, 5:08 PM

I feel like the most benefit will be in ones which cache the output, too. Dependencies are not that much faster. But avoiding image resizing, etc. cuts things down.

JJacob We're working on some behind-the-scenes work this week, but should have an updat...

itsmatteomanf•9/1/23, 11:38 AM

Can’t wait, as I just discovered Astro’s new image pipeline caches the images in node_modules. So it’s gonna speed up my build a lot

Iitsmatteomanf Can’t wait, as I just discovered Astro’s new image pipeline caches the images in...

James•9/1/23, 1:31 PM

Unlikely with the move to caching npm global cache and not node_modules. Caching node_modules in general is a bad idea, but maybe some allowlist of folders in node_modules to be restored after regular install would be good

itsmatteomanf•9/1/23, 1:36 PM

Oh yeah, right, it's the opposite

DaniFoldi•9/1/23, 1:37 PM

(you can customize the cache folder location in astro's config)

itsmatteomanf•9/1/23, 1:37 PM

But then, astro should probably do its own ~/.astro~/.astro folder in each project for caching.

DDaniFoldi (you can customize the cache folder location in astro's config)

itsmatteomanf•9/1/23, 1:37 PM

Yeah, I was remembering reading something like this.

Erisa•9/1/23, 1:38 PM

what if you put the cache in ~/.npm

itsmatteomanf•9/1/23, 1:38 PM

Yeah, not sure exactly what's now saved in this build image.

Erisa•9/1/23, 1:38 PM

(ok ideally pages would allow custom cache folders, im just being cheeky)

itsmatteomanf•9/1/23, 1:38 PM

@Jacob will be able to list the folders

JacobOP•9/1/23, 3:11 PM

If Astro uses something like node_modules/.cache then we could totally cache that

EErisa (ok ideally pages would allow custom cache folders, im just being cheeky)

JacobOP•9/1/23, 3:12 PM

One day

JJacob If Astro uses something like node_modules/.cache then we could totally cache tha...

itsmatteomanf•9/1/23, 4:42 PM

It’s actually .astro, but yes

itsmatteomanf•9/1/23, 4:42 PM

(In node_modules)

itsmatteomanf•9/1/23, 5:20 PM

I just filled the form again, I want to try it on Astro with a lot of images

itsmatteomanf•9/4/23, 12:10 PM

@Vero any chance to get the form looked at?

Iitsmatteomanf <@1052249953570918430> any chance to get the form looked at? 🙂

Vero•9/4/23, 12:11 PM

Today is a holiday in the US, so expect delays

itsmatteomanf•9/4/23, 12:11 PM

Oh... didn't know that NotLikeThis

itsmatteomanf•9/4/23, 12:11 PM

No prob

Vero•9/4/23, 12:11 PM

haha don't worry

Vero•9/4/23, 12:13 PM

but let me ask someone internally if they can enable it

itsmatteomanf•9/4/23, 12:13 PM

Don't worry too much

Iitsmatteomanf Don't worry too much 🙂

Vero•9/4/23, 12:16 PM

enabled

VVero enabled

itsmatteomanf•9/4/23, 12:16 PM

That was fast, thanks!

VVero enabled

itsmatteomanf•9/4/23, 12:22 PM

I'm not seeing that trying to fetch anything from cache... is it just production or preview, too?

Iitsmatteomanf I'm not seeing that trying to fetch anything from cache... is it just production...

Vero•9/4/23, 12:26 PM

it's for prod and preview too, he enabled both envs

VVero it's for prod and preview too, he enabled both envs

itsmatteomanf•9/4/23, 12:27 PM

Let me retry... but it's not showing anything regarding cache NotLikeThis

itsmatteomanf•9/4/23, 12:27 PM

I have retried a deployment, maybe it requires a new commit...?

itsmatteomanf•9/4/23, 12:31 PM

Nope, nothing

itsmatteomanf•9/4/23, 12:31 PM

Next attempt is new commit...

Vero•9/4/23, 12:38 PM

Hmm weird, I've asked internally but no response yet

Iitsmatteomanf Next attempt is new commit...

itsmatteomanf•9/4/23, 1:02 PM

Nope, this didn't seem to work either. I hoped when it took 30+ seconds initialize the environment lul

Iitsmatteomanf Nope, this didn't seem to work either. I hoped when it took 30+ seconds initiali...

Vero•9/4/23, 1:15 PM

well, let's wait for John and Jacob to get back to work

Vero•9/4/23, 1:35 PM

@itsmatteomanf Walshy just found the issue, is it working now?

VVero <@487247657736339456> Walshy just found the issue, is it working now?

itsmatteomanf•9/4/23, 1:35 PM

Retrying

Walshy, the savior lul

itsmatteomanf•9/4/23, 1:36 PM

Yes, shows the attempt to restore from cache!

Vero•9/4/23, 1:39 PM

yaay

itsmatteomanf•9/4/23, 1:49 PM

Questions for the team, once they actually get back, no rush:

Are there size limits for the cache?
I am not actually seeing the cache in
```
node_modules
```
```
node_modules
```
being used, so is every folder saved? Are .[folder].[folder] excluded?

Iitsmatteomanf Questions for the team, once they actually get back, no rush: - Are there size l...

Isaac McFadyen•9/4/23, 8:17 PM

AFAIK node_modules isn't cached.

Isaac McFadyen•9/4/23, 8:17 PM

Only ~/.npm is cached.

Isaac McFadyen•9/4/23, 8:17 PM

See James' comments above.

IIsaac McFadyen AFAIK node_modules isn't cached.

itsmatteomanf•9/4/23, 8:18 PM

I think it’s currently the opposite.

are you talking about caching with the new build caching, or the version that ships directly in the

Similar Threads

Similar Threads

Similar Threads