yeah just specialise it

T

TechPizza•10/20/23, 10:32 PM

eyo, don't bully my Vector<T> like that

PPerksey yeah just specialise it

M

Maxine•10/20/23, 10:32 PM

what do you mean by specialize

P

PerkseyOP•10/20/23, 10:33 PM

typeof(T) == typeof(double)

typeof(T) == typeof(double)

typeof(T) == typeof(double)

typeof(T) == typeof(double)

M

Maxine•10/20/23, 10:33 PM

yeah fair

T

TechPizza•10/20/23, 10:34 PM

if (typeof(T) == typeof(double) && Vector256.IsHardwareAccelerated)
{
    var _this = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(Z)), 
        0);
    
    var _other = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Z)), 
        0);

    return _this.Equals(_other);
}

if (typeof(T) == typeof(double) && Vector256.IsHardwareAccelerated)
{
    var _this = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(Z)), 
        0);
    
    var _other = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Z)), 
        0);

    return _this.Equals(_other);
}

if (typeof(T) == typeof(double) && Vector256.IsHardwareAccelerated)
{
    var _this = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(Z)), 
        0);
    
    var _other = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Z)), 
        0);

    return _this.Equals(_other);
}

if (typeof(T) == typeof(double) && Vector256.IsHardwareAccelerated)
{
    var _this = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(Z)), 
        0);
    
    var _other = Vector256.Create(
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.X)),
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Y)), 
        Unsafe.As<T, double>(ref Unsafe.AsRef(other.Z)), 
        0);

    return _this.Equals(_other);
}

is a little better

K

khitiara•10/20/23, 10:34 PM

also note silkx which this is to be a part of is intended to target net8 and up if any net8 optimizations impact things

TTechPizza ```cs if (typeof(T) == typeof(double) && Vector256.IsHardwareAccelerated) { ...

T

TechPizza•10/20/23, 10:35 PM

although net7 JIT can't e.g. see when you pass in constants, so it's pretty bad

P

PerkseyOP•10/20/23, 10:35 PM

we're all making coreclr optimisation assumptions here don't forget

P

PerkseyOP•10/20/23, 10:35 PM

mono does do intrinsics properly when used explicitly

Kkhitiara also note silkx which this is to be a part of is intended to target net8 and up ...

M

Maxine•10/20/23, 10:35 PM

i mean, if you can figure out a generalized vectorized Equals, i'd love to see it, this is where i stopped

        if (!RuntimeHelpers.IsReferenceOrContainsReferences<T>())
        {
            var size = Unsafe.SizeOf<T>();

            if (Vector128.IsHardwareAccelerated && (size * Count) < 16)
            {
                Span<byte> data = stackalloc byte[32];
                data.Clear(); // optional?

                var copy = this; // make you guys happy
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref copy, 1)).CopyTo(data);
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref other, 1)).CopyTo(data[16..]);
                
                MemoryMarshal.Cast<byte, Vector128<>()
            }
        }

        if (!RuntimeHelpers.IsReferenceOrContainsReferences<T>())
        {
            var size = Unsafe.SizeOf<T>();

            if (Vector128.IsHardwareAccelerated && (size * Count) < 16)
            {
                Span<byte> data = stackalloc byte[32];
                data.Clear(); // optional?

                var copy = this; // make you guys happy
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref copy, 1)).CopyTo(data);
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref other, 1)).CopyTo(data[16..]);
                
                MemoryMarshal.Cast<byte, Vector128<>()
            }
        }

        if (!RuntimeHelpers.IsReferenceOrContainsReferences<T>())
        {
            var size = Unsafe.SizeOf<T>();

            if (Vector128.IsHardwareAccelerated && (size * Count) < 16)
            {
                Span<byte> data = stackalloc byte[32];
                data.Clear(); // optional?

                var copy = this; // make you guys happy
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref copy, 1)).CopyTo(data);
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref other, 1)).CopyTo(data[16..]);
                
                MemoryMarshal.Cast<byte, Vector128<>()
            }
        }

        if (!RuntimeHelpers.IsReferenceOrContainsReferences<T>())
        {
            var size = Unsafe.SizeOf<T>();

            if (Vector128.IsHardwareAccelerated && (size * Count) < 16)
            {
                Span<byte> data = stackalloc byte[32];
                data.Clear(); // optional?

                var copy = this; // make you guys happy
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref copy, 1)).CopyTo(data);
                MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref other, 1)).CopyTo(data[16..]);
                
                MemoryMarshal.Cast<byte, Vector128<>()
            }
        }

M

Maxine•10/20/23, 10:36 PM

it's very annoying without scoping T to struct

K

khitiara•10/20/23, 10:36 PM

yeah without scoping T : struct idk how to do it

M

Maxine•10/20/23, 10:36 PM

can i call low-level SIMD instructions direclty? :3

A

Aqua•10/20/23, 10:37 PM

like

Sse2.Add

Sse2.Add

Sse2.Add

Sse2.Add?

M

Maxine•10/20/23, 10:37 PM

yeah

P

PerkseyOP•10/20/23, 10:37 PM

System.Runtime.Intrinsics.X86 (and friends)

M

Maxine•10/20/23, 10:37 PM

that might work

M

Maxine•10/20/23, 10:38 PM

casting a Vector3<int> to Vector3 (float) for equality should be fine, right

M

Maxine•10/20/23, 10:38 PM

since it's just a memory comparison

A

Aqua•10/20/23, 10:38 PM

eehhhh
i really don't see how this is any faster than just doing a logical compare

AAqua eehhhh i really don't see how this is any faster than just doing a logical compa...

M

Maxine•10/20/23, 10:38 PM

for AsVector128

MMaxine casting a Vector3<int> to Vector3 (float) for equality should be fine, right

T

TechPizza•10/20/23, 10:39 PM

throws out all float rules out of window i see

P

PerkseyOP•10/20/23, 10:39 PM

doesn't Span have a really efficient equality implementation already?

A

Aqua•10/20/23, 10:39 PM

intrinsics can often be slower if you're just using them for one singular operation

MMaxine casting a Vector3<int> to Vector3 (float) for equality should be fine, right

P

PerkseyOP•10/20/23, 10:39 PM

// USE AN EPSILON DAMNIT!

// USE AN EPSILON DAMNIT!

// USE AN EPSILON DAMNIT!

// USE AN EPSILON DAMNIT!

PPerksey doesn't Span have a really efficient equality implementation already?

M

Maxine•10/20/23, 10:39 PM

so i should just create a Span<T> for this and other and equals that?

M

Maxine•10/20/23, 10:39 PM

that would both be generalizable and fast

M

Maxine•10/20/23, 10:39 PM

possibly

M

Maxine•10/20/23, 10:39 PM

if the JIT created the right instructions

P

PerkseyOP•10/20/23, 10:40 PM

sure but you're trading correctness for performance

M

Maxine•10/20/23, 10:40 PM

what do you mean correctness, Vector3 Equals was never meant to use an epsilon

P

PerkseyOP•10/20/23, 10:40 PM

it is conceivably possible that the same effective float value has differing bits

M

Maxine•10/20/23, 10:41 PM

yep i just figured out why this wouldn't work

M

Maxine•10/20/23, 10:41 PM

things like -0 and +0

M

Maxine•10/20/23, 10:41 PM

NaN equality

PPerksey sure but you're trading correctness for performance

A

Aqua•10/20/23, 10:41 PM

i'm not even sure it would be more performant

A

Aqua•10/20/23, 10:41 PM

or if it is, its negligable

P

PerkseyOP•10/20/23, 10:41 PM

it'd be more performant for gigantic structs

A

Aqua•10/20/23, 10:41 PM

you're replacing instructions with other instructions

A

Aqua•10/20/23, 10:41 PM

true, but not for a small one like vectors

A

Aqua•10/20/23, 10:41 PM

matrix probably

P

PerkseyOP•10/20/23, 10:41 PM

oh yeah

A

Aqua•10/20/23, 10:41 PM

but not vectors

P

PerkseyOP•10/20/23, 10:41 PM

like seriously please just use specialised impls

AAqua i'm not even sure it would be more performant

M

Maxine•10/20/23, 10:42 PM

i jsut adapted this

A

Aqua•10/20/23, 10:42 PM

maybe there is something i am missing ¯\_(ツ)_/¯

M

Maxine•10/20/23, 10:42 PM

should i throw this all out and jus compare XYZ? that's fine with me

A

Aqua•10/20/23, 10:42 PM

i've done the experiments with SIMD and vectors

A

Aqua•10/20/23, 10:43 PM

and in my tests its far slower than to just do the operations directly

A

Aqua•10/20/23, 10:43 PM

because of the amount of extra bulk that goes along with it

yeah just specialise it

Similar Threads

Similar Threads

Similar Threads