Cloudflare Developers•3y ago

hey there, if i were to create a worker that responds with a pretty large image 😅, would it be auto

hey there, if i were to create a worker that responds with a pretty large image

, would it be automatically streamed? are there any automatic optimisations cloudflare does?

Mmooon hey there, if i were to create a worker that responds with a pretty large image ...

Bulbasaur•11/19/23, 11:15 PM

as long as you don't buffer the image in memory, then it will be streamed

Bulbasaur•11/19/23, 11:15 PM

the key is to avoid reading the

Response

Response

body of any request to the image you make into memory

Bulbasaur•11/19/23, 11:18 PM

So avoid calling all of these basically, except Response.cloneResponse.clone is fine -

Bulbasaur•11/19/23, 11:19 PM

If you do buffer the body in the worker, then the worker will first wait all the time to fetch the image itself and load it into memory, then respond with it, slowing it down.

Bulbasaur•11/19/23, 11:19 PM

On the client side (e.g in a browser), whether or not the worker buffers it in memory or not shouldn't have any impact, it can still be streamed as normal

TheKaiser•11/20/23, 12:59 AM

does anyone have advice on how to do typing when using itty-router-openapi? I've been using zod's infer() to create a type but I'd love to have typing for the "data" argument in handle, all the documentation just sets it to "any"

Colin•11/20/23, 1:21 AM

I'm encountering some confusing Worker runtime behavior, would love if anyone more seasoned could chime in

basically:

We have a WebSocket opened to a Worker (not a DO, just plain worker)
When the client closes the WebSocket first, the Worker emits a WebSocket disconnected without sending Close frame.WebSocket disconnected without sending Close frame.
The Worker emits a Network connection lost.Network connection lost.
This is counted as a "Script Threw Exception" from Cloudflare's dashboard/api/logpush

My understanding was that the WebSocket disconnect + network connection lost just indicate the client going away + the isolate terminating, which is expected behavior. However, why is this counted as an exception instead of a "Client disconnected" (what I'd expect + what standard HTTP requests do when the client disappears) or anything else?

(Why do we care in the first place? We have some monitoring + logpush configured only for errors, and these "false errors" create noise in those systems)

kian•11/20/23, 1:28 AM

The exceptionexception outcome is for any unhandled exception, which Network connection lostNetwork connection lost would be. The errors around WebSockets aren't ideal, and https://github.com/cloudflare/workerd/pull/804 hopes to improve them.

Kkian The `exception` outcome is for any unhandled exception, which `Network connectio...

Colin•11/20/23, 1:53 AM

I guess I'm confused how to prevent Network connection lostNetwork connection lost here - I assume that's what error messages generated by that PR should tell us?

It looks like that PR has been untouched for 3 months-ish, do you know what the status is or should I leave a comment?

nEEk•11/20/23, 8:35 AM

I'm building a ticketing system and need puppeteer for pdf screenshots. Any eta on when @cloudflare/puppeteer will be available to use in workers? Super keen for this since it will mean I can migrate to Cloudflare from vercel, render.com and aws.

.gwapes•11/20/23, 12:03 PM

Hey, I’m using my own express server hosted on my vps to handle request for database updating, and then making the requests on my worker to update things in my database (mongodb)

What is a good way to authorise this? To make sure no one can make random PATCH requests for example? Atm, I’m just using an authorisation header with a random string and then checkin that on my express server. Is there a better way?

.gwapes•11/20/23, 12:04 PM

It’s only for something small so it doesn’t matter really but it’s more of a learning thing

..gwapes Hey, I’m using my own express server hosted on my vps to handle request for data...

Hello, I’m Allie!•11/20/23, 12:05 PM

Create a DNS record for it, then put the Worker on top.

Hello, I’m Allie!•11/20/23, 12:06 PM

Then all requests hitting your origin have to pass through your Worker first, where you are free to accept/deny

.gwapes•11/20/23, 12:07 PM

So I’d check if it was a patch, and the route was the specific route that would be on my express server?

..gwapes So I’d check if it was a patch, and the route was the specific route that would ...

Hello, I’m Allie!•11/20/23, 12:08 PM

That, or just never pass a request back to your origin unless it is you making a DB request

.gwapes•11/20/23, 12:08 PM

And how would I make sure it was my worker

.gwapes•11/20/23, 12:09 PM

Also, is it not very optimal to just have an authorisation header?

..gwapes And how would I make sure it was my worker

Hello, I’m Allie!•11/20/23, 12:10 PM

You could use a Tunnel, and then not expose the server at all

..gwapes Also, is it not very optimal to just have an authorisation header?

Hello, I’m Allie!•11/20/23, 12:11 PM

You can, but with this method, you literally can't hit the origin at all(barring any issues on CF's side), while with the Auth Header method, a bad actor can still hammer your DB with requests, even if they aren't authorized

.gwapes•11/20/23, 12:12 PM

I’m a bit lost with the last part there. I only actually make the db update if the auth headers value is that “random string”, so it won’t do anything if it’s not right

HHello, I’m Allie!You could use a Tunnel, and then not expose the server at all

.gwapes•11/20/23, 12:12 PM

Is there any docs/examples on tunnelling?

..gwapes I’m a bit lost with the last part there. I only actually make the db update if t...

Hello, I’m Allie!•11/20/23, 12:13 PM

Yes, but in this case, if I want to take your DB out of commision, I can just send random requests to your server. The changes won't be able to be applied, but because your server is busy handling my requests, it won't have time to handle your valid changes

..gwapes Is there any docs/examples on tunnelling?

Hello, I’m Allie!•11/20/23, 12:13 PM

https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/get-started/create-remote-tunnel/

Create a remotely-managed tunnel (dashboard) · Cloudflare Zero Trus...

Follow this step-by-step guide to get your first tunnel up and running using Zero Trust.

HHello, I’m Allie!Yes, but in this case, if I want to take your DB out of commision, I can just se...

.gwapes•11/20/23, 12:13 PM

But that would be an express like thing, right? Rather then a db thing. Because it’s just busy not doing anything but handling the wrong requests

.gwapes•11/20/23, 12:14 PM

So it would be better to return wrong requests from my cf worker where everything goes through anyway?

..gwapes So it would be better to return wrong requests from my cf worker where everythin...

Hello, I’m Allie!•11/20/23, 12:14 PM

Yes, because no matter how beefy your server is, Workers will be able to burst to much higher capacity than Express

..gwapes But that would be an express like thing, right? Rather then a db thing. Because ...

.gwapes•11/20/23, 12:15 PM

Doing nothing*

.gwapes•11/20/23, 12:15 PM

Gotcha

.gwapes•11/20/23, 12:15 PM

Thanks so much, was really helpful

HHello, I’m Allie!That, or just never pass a request back to your origin unless it is **you** maki...

.gwapes•11/20/23, 12:17 PM

Just to confirm, I can still use the auth header method, right? Just instead using the worker to say yes or no

..gwapes Just to confirm, I can still *use* the auth header method, right? Just instead u...

Hello, I’m Allie!•11/20/23, 12:18 PM

Yeah, you could

.gwapes•11/20/23, 12:18 PM

Awesome, thanks

.gwapes•11/20/23, 1:26 PM

Is there an npm package or something similar for how to type the context param here

export default {
  async fetch(request, env, context) {
    // Proxy to origin on unhandled/uncaught exceptions
    context.passThroughOnException();
    throw new Error('Oops');
  },
};

export default {
  async fetch(request, env, context) {
    // Proxy to origin on unhandled/uncaught exceptions
    context.passThroughOnException();
    throw new Error('Oops');
  },
};

.gwapes•11/20/23, 1:28 PM

nvm got it

kian•11/20/23, 5:31 PM

Try