downgrade the version of Wrangler to 3.61.0 or less and directly use "wrangler dev" command

MMayuresh Choudhary downgrade the version of Wrangler to 3.61.0 or less and directly use "wrangler ...

N

Nima•7/1/24, 8:14 AM

Ty

V

Vero•7/1/24, 3:15 PM

Hellooo devs. See you July 1, 2024 for our @Wrangler office hours
https://discord.gg/cloudflaredev?event=1255538131910787134

A

AteMyCats•7/1/24, 3:18 PM

bro why ping

A

AteMyCats•7/1/24, 3:18 PM

u eoke me up

A

AteMyCats•7/1/24, 3:18 PM

meanie

Z

ZachHandley•7/1/24, 3:32 PM

lol take away the wrangler role yeah

T

Tin Cap•7/1/24, 4:02 PM

Why did I get invited into that with a notification?

T

Tin Cap•7/1/24, 4:55 PM

Been in this discord for a few years. Never got a notification that opened a live chat before.

R

Ruxorly•7/1/24, 5:32 PM

probably update

A

Aditya Mathur•7/1/24, 6:43 PM

Hello! I am using

WorkerKV

WorkerKV

for some experiment and this is my code

await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
  expiration: Math.floor(payload.resetTime.getTime() / 1000),
});

await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
  expiration: Math.floor(payload.resetTime.getTime() / 1000),
});

await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
  expiration: Math.floor(payload.resetTime.getTime() / 1000),
});

await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
  expiration: Math.floor(payload.resetTime.getTime() / 1000),
});

So here are the problems I am facing -

The key is not getting deleted, I am still getting the old value when I fetch it
If I want to update the value for a key but still want to have the same expiration time, what will be implmentation for that? Should I just pass the
```
expiration
```
```
expiration
```
props again?

AAditya Mathur Hello! I am using `WorkerKV` for some experiment and this is my code ```ts awai...

H

Hello, I’m Allie!•7/1/24, 6:47 PM

Does it expire after a minute or so?
And yes, on your second one

HHello, I’m Allie!Does it expire after a minute or so? And yes, on your second one

A

Aditya Mathur•7/1/24, 6:52 PM

A

Aditya Mathur•7/1/24, 6:53 PM

Here is the code -

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);
    // @ts-ignore
    let payload: Required<ClientRateLimitInfo> = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const wasCreated = payload != null

    if (wasCreated) payload = {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime),
    };
    else
      payload = {
        totalHits: 1,
        resetTime: new Date(Date.now() + this.windowMs),
      };

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expiration: !wasCreated ? Math.floor(payload.resetTime.getTime() / 1000) : undefined,
      // expirationTtl: this.windowMs
    });

    return payload;
  }

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);
    // @ts-ignore
    let payload: Required<ClientRateLimitInfo> = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const wasCreated = payload != null

    if (wasCreated) payload = {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime),
    };
    else
      payload = {
        totalHits: 1,
        resetTime: new Date(Date.now() + this.windowMs),
      };

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expiration: !wasCreated ? Math.floor(payload.resetTime.getTime() / 1000) : undefined,
      // expirationTtl: this.windowMs
    });

    return payload;
  }

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);
    // @ts-ignore
    let payload: Required<ClientRateLimitInfo> = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const wasCreated = payload != null

    if (wasCreated) payload = {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime),
    };
    else
      payload = {
        totalHits: 1,
        resetTime: new Date(Date.now() + this.windowMs),
      };

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expiration: !wasCreated ? Math.floor(payload.resetTime.getTime() / 1000) : undefined,
      // expirationTtl: this.windowMs
    });

    return payload;
  }

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);
    // @ts-ignore
    let payload: Required<ClientRateLimitInfo> = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const wasCreated = payload != null

    if (wasCreated) payload = {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime),
    };
    else
      payload = {
        totalHits: 1,
        resetTime: new Date(Date.now() + this.windowMs),
      };

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expiration: !wasCreated ? Math.floor(payload.resetTime.getTime() / 1000) : undefined,
      // expirationTtl: this.windowMs
    });

    return payload;
  }

A

Aditya Mathur•7/1/24, 6:54 PM

this.windowMs = 60_000 // 1 minute

this.windowMs = 60_000 // 1 minute

AAditya Mathur Here is the code - ```ts async increment(key: string): Promise<ClientRateLimitIn...

A

Aditya Mathur•7/2/24, 3:26 AM

Hey @Hello, I’m Allie!, do you know what am I doing wrong?

AAditya Mathur Hey @Hello, I’m Allie!, do you know what am I doing wrong?

I

Ian•7/2/24, 3:33 AM

was it the if statement?

IIan was it the if statement?

A

Aditya Mathur•7/2/24, 3:37 AM

?

I

Ian•7/2/24, 3:37 AM

by the way, you'd be better served using a ternary instead of an if statement since a ternary always assigns something.

const payload = wasCreated
  ? {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime)
    }
  : {
       totalHits: 1,
       resetTime: new Date(Date.now() + this.windowMs),
    }

const payload = wasCreated
  ? {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime)
    }
  : {
       totalHits: 1,
       resetTime: new Date(Date.now() + this.windowMs),
    }

const payload = wasCreated
  ? {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime)
    }
  : {
       totalHits: 1,
       resetTime: new Date(Date.now() + this.windowMs),
    }

const payload = wasCreated
  ? {
      totalHits: payload.totalHits + 1,
      resetTime: new Date(payload.resetTime)
    }
  : {
       totalHits: 1,
       resetTime: new Date(Date.now() + this.windowMs),
    }

Now payload is always assigned a value

AAditya Mathur ?

I

Ian•7/2/24, 3:37 AM

Oh I see, you were asking for help. I thought you were saying you figured it out and wanted to let @Hello, I’m Allie! know how you fixed it.

I

Ian•7/2/24, 3:38 AM

I think your problem is your if statement. It has a semicolon before the

else

else

clause. Try the following

I

Ian•7/2/24, 3:39 AM

if (wasCreated) {
  payload = {
    totalHits: payload.totalHits + 1,
    resetTime: new Date(payload.resetTime),
  }; // <-- semicolon here
} else {  // <-- not here
  payload = {
    totalHits: 1,
    resetTime: new Date(Date.now() + this.windowMs),
  };
}

if (wasCreated) {
  payload = {
    totalHits: payload.totalHits + 1,
    resetTime: new Date(payload.resetTime),
  }; // <-- semicolon here
} else {  // <-- not here
  payload = {
    totalHits: 1,
    resetTime: new Date(Date.now() + this.windowMs),
  };
}

if (wasCreated) {
  payload = {
    totalHits: payload.totalHits + 1,
    resetTime: new Date(payload.resetTime),
  }; // <-- semicolon here
} else {  // <-- not here
  payload = {
    totalHits: 1,
    resetTime: new Date(Date.now() + this.windowMs),
  };
}

if (wasCreated) {
  payload = {
    totalHits: payload.totalHits + 1,
    resetTime: new Date(payload.resetTime),
  }; // <-- semicolon here
} else {  // <-- not here
  payload = {
    totalHits: 1,
    resetTime: new Date(Date.now() + this.windowMs),
  };
}

IIan I think your problem is your if statement. It has a semicolon before the `else` ...

A

Aditya Mathur•7/2/24, 3:40 AM

I don't think so, but just give me a sec let me try

I

Ian•7/2/24, 3:40 AM

even if it's somehow valid syntax, it's a very odd way of doing an if/else

IIan even if it's somehow valid syntax, it's a very odd way of doing an if/else

A

Aditya Mathur•7/2/24, 3:43 AM

Yeah, I was just prototyping, so was not really looking into making it look good. But you are right about that, it does look odd

IIan even if it's somehow valid syntax, it's a very odd way of doing an if/else

A

Aditya Mathur•7/2/24, 3:46 AM

Nope, this was not it.

AAditya Mathur Hello! I am using `WorkerKV` for some experiment and this is my code ```ts awai...

A

Aditya Mathur•7/2/24, 3:52 AM

Hey @Community Champion guys, sorry for pinning you like this but I am stuck on this for a week. Does anyone knows what is wrong in this?

A

andrew_nyr•7/2/24, 4:00 AM

?pings

F

Flare•7/2/24, 4:00 AM

Please do not ping community members for non-moderation reasons. Doing so will not solve your issue faster and will make people less likely to want to help you.

A

Aditya Mathur•7/2/24, 4:20 AM

okay

I

Ian•7/2/24, 5:07 AM

@Aditya Mathur are you sure you meant to use

expiration

expiration

(seconds since the epoch) or

expirationTtl

expirationTtl

(seconds from now) ? Because I saw your

this.windowMs = 60_000 // 1 minute

this.windowMs = 60_000 // 1 minute

comment, but you also have

expirationTtl: this.windowMs

expirationTtl: this.windowMs

and that would be wrong; it would be 60000 seconds.

IIan @Aditya Mathur are you sure you meant to use `expiration` (seconds since the epo...

A

Aditya Mathur•7/2/24, 5:13 AM

Yeah, you are right about that but it is commented, so it is not getting executed. This is a rate limiter, so the problem is every time a user requests the server I have to update the

totalHits

totalHits

but the expiration time remains that same, thats why it is stored in

resetTime

resetTime

. So when I am updating it, I am passing the

expiration

expiration

again.

I

Ian•7/2/24, 5:14 AM

In the docs

As of January 2022, expiration targets that are less than 60 seconds into the future are not supported. This is true for both expiration methods.

I

Ian•7/2/24, 5:16 AM

@Aditya Mathur when you read the KV, doesn't it also contain the

expiration

expiration

attribute?

I

Ian•7/2/24, 5:17 AM

If so, just merge a default payload with a payload that it found...

A

Aditya Mathur•7/2/24, 5:18 AM

So what you are saying is, by updating the entry I am not overwriting the

expiration

expiration

?

I

Ian•7/2/24, 5:19 AM

yeah, don't bother updating expiration since it's basically "expires at Time", while the expirationTtl is "expires in X"

I

Ian•7/2/24, 5:20 AM

expiration is relative to a fixed point in time, the epoch. while expirationTtl is relative to right now.

I

Ian•7/2/24, 5:21 AM

so do this

have a default payload
get the KV
merge it with the default payload using spread operations
put the KV

A

Aditya Mathur•7/2/24, 5:22 AM

Okay let me try this

AAditya Mathur Okay let me try this

I

Ian•7/2/24, 5:24 AM

Something like this

const defaultPayload = {
  hits: 1,
  expiration: new Date(new Date().getTime() + 60_000),
}

const record = await env.NAMESPACE.get('key', { type: 'json' })

const payload = {
  ...defaultPayload,
  ...(record ?? {}), // if record is nullish, spread an empty object in its place
}

await env.NAMESPACE.put('key', payload, { expiration: payload.expiration })

const defaultPayload = {
  hits: 1,
  expiration: new Date(new Date().getTime() + 60_000),
}

const record = await env.NAMESPACE.get('key', { type: 'json' })

const payload = {
  ...defaultPayload,
  ...(record ?? {}), // if record is nullish, spread an empty object in its place
}

await env.NAMESPACE.put('key', payload, { expiration: payload.expiration })

const defaultPayload = {
  hits: 1,
  expiration: new Date(new Date().getTime() + 60_000),
}

const record = await env.NAMESPACE.get('key', { type: 'json' })

const payload = {
  ...defaultPayload,
  ...(record ?? {}), // if record is nullish, spread an empty object in its place
}

await env.NAMESPACE.put('key', payload, { expiration: payload.expiration })

const defaultPayload = {
  hits: 1,
  expiration: new Date(new Date().getTime() + 60_000),
}

const record = await env.NAMESPACE.get('key', { type: 'json' })

const payload = {
  ...defaultPayload,
  ...(record ?? {}), // if record is nullish, spread an empty object in its place
}

await env.NAMESPACE.put('key', payload, { expiration: payload.expiration })

IIan Something like this ```typescript const defaultPayload = { hits: 1, expirati...

A

Aditya Mathur•7/2/24, 5:35 AM

No Luck

A

Aditya Mathur•7/2/24, 5:36 AM

Here is the code -

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);

    const defaultPayload = {
      totalHits: 1,
      resetTime: new Date(Date.now() + this.windowMs),
    }

    // @ts-ignore
    const record: Required<ClientRateLimitInfo> | null = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const payload = { ...defaultPayload, ...(record ? { totalHits: record.totalHits + 1, resetTime: new Date(record.resetTime) } : {}) }

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expirationTtl: !record ? payload.resetTime.getTime() / 1000 : undefined,
    });

    return payload;
  }

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);

    const defaultPayload = {
      totalHits: 1,
      resetTime: new Date(Date.now() + this.windowMs),
    }

    // @ts-ignore
    const record: Required<ClientRateLimitInfo> | null = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const payload = { ...defaultPayload, ...(record ? { totalHits: record.totalHits + 1, resetTime: new Date(record.resetTime) } : {}) }

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expirationTtl: !record ? payload.resetTime.getTime() / 1000 : undefined,
    });

    return payload;
  }

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);

    const defaultPayload = {
      totalHits: 1,
      resetTime: new Date(Date.now() + this.windowMs),
    }

    // @ts-ignore
    const record: Required<ClientRateLimitInfo> | null = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const payload = { ...defaultPayload, ...(record ? { totalHits: record.totalHits + 1, resetTime: new Date(record.resetTime) } : {}) }

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expirationTtl: !record ? payload.resetTime.getTime() / 1000 : undefined,
    });

    return payload;
  }

async increment(key: string): Promise<ClientRateLimitInfo> {
    const keyWithPrefix = this.prefixKey(key);

    const defaultPayload = {
      totalHits: 1,
      resetTime: new Date(Date.now() + this.windowMs),
    }

    // @ts-ignore
    const record: Required<ClientRateLimitInfo> | null = await this.namespace.get<Required<ClientRateLimitInfo>>(
      keyWithPrefix,
      "json",
    );

    const payload = { ...defaultPayload, ...(record ? { totalHits: record.totalHits + 1, resetTime: new Date(record.resetTime) } : {}) }

    console.log("Payload - ", payload, " Expire - ", payload.resetTime.toLocaleString(), " Current - ", new Date().toLocaleString())

    await this.namespace.put(keyWithPrefix, JSON.stringify(payload), {
      expirationTtl: !record ? payload.resetTime.getTime() / 1000 : undefined,
    });

    return payload;
  }

A

Aditya Mathur•7/2/24, 5:59 AM

Is there a working example of using