The builds look to be only the proprietary builds. https://github.com/ublue-os/akmods/actions/runs

The builds look to be only the proprietary builds.
https://github.com/ublue-os/akmods/actions/runs/10303593550/job/28521223762?pr=225#step:12:2110

Whereas if you look at an existing open kernel module build:

Dual MIT/GPL
Dual MIT/GPL
Dual MIT/GPL
Dual BSD/GPL
Dual MIT/GPL

Dual MIT/GPL
Dual MIT/GPL
Dual MIT/GPL
Dual BSD/GPL
Dual MIT/GPL

Dual MIT/GPL
Dual MIT/GPL
Dual MIT/GPL
Dual BSD/GPL
Dual MIT/GPL

Dual MIT/GPL
Dual MIT/GPL
Dual MIT/GPL
Dual BSD/GPL
Dual MIT/GPL

https://github.com/ublue-os/akmods/actions/runs/10294789438/job/28493399255#step:12:2111

Dylan•8/8/24, 2:52 PM

Looking

Dylan•8/8/24, 2:54 PM

The NVIDIA_FLAVOR variable is making it to the build. I wonder if it is not being consumed right.

Dylan•8/8/24, 2:55 PM

As it is getting used in the containerfile

Dylan•8/8/24, 2:55 PM

Ohhhhhhhh I'm passing the wrong thing to the build kmod

Dylan•8/8/24, 2:56 PM

It expects kernel-open or kernel not nvidia or nvidia-open

Dylan•8/8/24, 3:06 PM

I think I have a fix in for it now

Dylan•8/8/24, 3:06 PM

Can you reapprove the workflow

RRobert The builds look to be only the proprietary builds. https://github.com/ublue-os...

Dylan•8/8/24, 3:08 PM

This was almost certainly it. https://github.com/ublue-os/akmods/pull/225/commits/fcbdaa304b60faa5e577ddaed499480030986108

Dylan•8/8/24, 3:12 PM

Okay now it has a syntax error.

Dylan•8/8/24, 3:15 PM

Oh, I think I see it. else instead of fi here.

Dylan•8/8/24, 3:21 PM

Let me dig into that some more. Looks to still be failing

Dylan•8/8/24, 3:29 PM

The if statement parsing was a bit hard, so I'm trying a different way to see if that works.

Dylan•8/8/24, 3:29 PM

That should function as intended.

Dylan•8/8/24, 3:35 PM

I want to say it's probably good now and might work when the workflow is reapproved, but I can't get it to build on my personal fork - so no promises

RobertOP•8/8/24, 3:57 PM

Where are the container policies being added to the images? I know they are defined in ublue-os/config, but wondering how we should get them over to Cosmic.
I kinda expected them to be added in ublue-os/main, which cosmic inherits

Dylan•8/8/24, 3:58 PM

I'm seeing

Dual MIT/GPL
Dual MIT/GPL
Dual MIT/GPL
Dual BSD/GPL
Dual MIT/GPL

on both now. Which is better than it failing but something is off.

RRobert Where are the container policies being added to the images? I know they are def...

M2•8/8/24, 3:59 PM

they should be in ublue-os/main

Dylan•8/8/24, 4:00 PM

I think this is really close. Need to figure out why it's building the wrong one on legacy then fix that

MM2 they should be in ublue-os/main

RobertOP•8/8/24, 4:01 PM

Ah, so I can see the public key in the image (maybe from the ISO?) but there's strangely just the default InsecureAcceptAnything container policy.

M2•8/8/24, 4:01 PM

in cosmic or main?

RobertOP•8/8/24, 4:02 PM

In cosmic

RobertOP•8/8/24, 4:02 PM

But I guess since it's the default policy in cosmic, it's also in main-base?

M2•8/8/24, 4:03 PM

cosmic-base should be base-main + copr repos

M2•8/8/24, 4:05 PM

main-base has our policy in /usr/etc/containers/policy.json. It has the default in /etc/containers/policy.json

RobertOP•8/8/24, 4:05 PM

In cosmic

RRobert In cosmic

antheas•8/8/24, 4:05 PM

do you use rechunk 0.8.1 or 0.8.0

antheas•8/8/24, 4:06 PM

rechunk 0.8.1 will use /usr/etc and 0.8.0 will use /etc

antheas•8/8/24, 4:06 PM

we verified 0.8.1 will use the correct policy on bazzite and i prd it yesterday

antheas•8/8/24, 4:06 PM

for cosmic

RobertOP•8/8/24, 4:06 PM

It was whatever the ISOs were built with.
Will spin some new ISOs

antheas•8/8/24, 4:06 PM

check the container image by booting with bash

antheas•8/8/24, 4:07 PM

the correct oen should be in /etc

antheas•8/8/24, 4:07 PM

not booting by running bash on it

antheas•8/8/24, 4:07 PM

there should not be a /usr/etc dir

Kyle Gospo•8/8/24, 4:10 PM

@M2 @Robert (p5) got an interesting issue we need to fix

Kyle Gospo•8/8/24, 4:10 PM

as part of moving /usr/etc to /etc, it turns out we were replacing a file in /etc/ provided by a core package by putting the replacement in /usr/etc

Kyle Gospo•8/8/24, 4:10 PM

that's the container update policy

Kyle Gospo•8/8/24, 4:11 PM

we need to either
1: Remove it from the signing RPM and replace in the main/ucore image
2: Make our signing rpm provide container-common (Will require us to keep it up to date, not a great concept)
3: Install with --force-allowreplace separately from our other rpms

RobertOP•8/8/24, 4:12 PM

If I understand correctly:
Fedora provides /etc/containers/policy.json in their image
We now try to add our own /etc/containers/policy.json
Adding our policy fails
?

Kyle Gospo•8/8/24, 4:13 PM

yes and yes

Kyle Gospo•8/8/24, 4:13 PM

previously we added it to /usr/etc/containers/policy.json

Kyle Gospo•8/8/24, 4:13 PM

which did not conflict, but adding to /usr/etc is undefined behavior according to Colins

Kyle Gospo•8/8/24, 4:13 PM

so now our signing rpm fails to install w/ that error

RobertOP•8/8/24, 4:14 PM

And (knowing nothing about RPMs) we can't add a PREINSTALL step to the signing RPM which deletes the original file if present?

Kyle Gospo•8/8/24, 4:14 PM

yes that would work

Kyle Gospo•8/8/24, 4:14 PM

as would the force replace param

KKyle Gospo which did not conflict, but adding to /usr/etc is undefined behavior according t...

antheas•8/8/24, 4:16 PM

according to me, i dont think colin ever considered it

antheas•8/8/24, 4:16 PM

tbh

antheas•8/8/24, 4:16 PM

rpm-ostree just mashes the directories together

Aantheas according to me, i dont think colin ever considered it

Kyle Gospo•8/8/24, 4:16 PM

whar that's not what you said, well regardless we are here

The builds look to be only the proprietary builds. https://github.com/ublue-os/akmods/actions/runs

Similar Threads

Similar Threads

Similar Threads