50 replies

Draft: feat: Add featured apps configura...

i did put in this PR for KDE discover. we'll see if it ends up being accepted. but if it does, thats one less thing to have to rely on

yafti

yafti

yafti

yafti for so it can be streamlined

GitLab

Draft: feat: Add featured apps configurable URL (!933) · Merge requ...

Add function to check config for featured URL closes

jardonOP•9/18/24, 10:15 PM

creating thread in case its helpful

jardonOP•9/19/24, 2:50 PM

@��onomist sorry i should use the thread i created

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 2:50 PM

yeah i eventually saw it

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 2:50 PM

i agree with your idea

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 2:51 PM

ill updoot

jardonOP•9/19/24, 2:51 PM

requiring each downstream distro to have to build it themselves is not great

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 2:59 PM

@jardon

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 2:59 PM

jardonOP•9/19/24, 3:01 PM

seems rational and reasonable to me

jardonOP•9/19/24, 3:02 PM

it seems like a weird thing to worry about modification of the featured list. i mean it doesnt have any impact on software sources ya know?

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:02 PM

"i think youre failing to consider" is maybe a little accusative towards president of kde

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:03 PM

lmao

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:03 PM

i should chill a bit but yeah

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:03 PM

i think your idea is better

jardonOP•9/19/24, 3:04 PM

ya the first part is the least chill. the two paragraphs after are at least really grounded in fact

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:04 PM

yeah i posted

jardonOP•9/19/24, 3:04 PM

i honestly didnt know he was the president

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:04 PM

i am a yapping machine

jardonOP•9/19/24, 3:04 PM

thanks for weighing in. hopefully it helps

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:05 PM

there are so many things that a user process could override easily in KDE

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:05 PM

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:05 PM

that's just how KConfig works

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:05 PM

readable plain text files

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:05 PM

if that's somehow a problem then why offer any settings at all :pepelaugh:

jardonOP•9/19/24, 3:10 PM

the joys of collaboration

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:10 PM

idk if theres a .kcfgc file u would need to add it to

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:10 PM

idk how discover does it

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:11 PM

looks like it does it in a weird way

jardonOP•9/19/24, 3:14 PM

i wonder if hes worried more about the desktop vs mobile configs and it featuring very not optimized desktop apps on mobile

Jjardon i wonder if hes worried more about the desktop vs mobile configs and it featurin...

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 3:24 PM

That is whoever sets the file's problem

jardonOP•9/19/24, 3:32 PM

I don't disagree

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 11:53 PM

@jardon well now your solution is getting code reviewed

�

𝓯𝓻𝓮𝓪𝓴onomist•9/19/24, 11:53 PM

Lol

jardonOP•9/19/24, 11:54 PM

i just saw that!

jardonOP•9/19/24, 11:58 PM

t e a m w o r k

jardonOP•9/20/24, 12:08 AM

you have any thoughts on his feedback?

jardonOP•9/20/24, 12:10 AM

im really not sure why he's so worried about the featured list like messing with it is going to install malware

jardonOP•9/20/24, 12:15 AM

@��onomist

Jjardon im really not sure why he's so worried about the featured list like messing with...

�

𝓯𝓻𝓮𝓪𝓴onomist•9/20/24, 12:18 AM

Yeah not a huge deal

jardonOP•9/20/24, 11:38 AM

i still dont like the compromise, but maybe i should just take what i can get

jardonOP•9/20/24, 11:38 AM

if it works then great

jardonOP•9/20/24, 11:38 AM

its not like i even like kde

Jjardon its not like i even like kde

�

𝓯𝓻𝓮𝓪𝓴onomist•9/21/24, 2:31 AM

I like kde

�

𝓯𝓻𝓮𝓪𝓴onomist•9/21/24, 2:31 AM

also nate the pull request beast himself agrees with your idea instead

jardonOP•9/21/24, 1:07 PM

Do you have the ability to build and test my PR? I don't have a environment set up for it and the in-laws are in town

Jjardon Do you have the ability to build and test my PR? I don't have a environment set ...

�

𝓯𝓻𝓮𝓪𝓴onomist•9/22/24, 4:44 PM

not right now

�

𝓯𝓻𝓮𝓪𝓴onomist•10/2/24, 4:20 PM

@jardon let Mr president eat his dinner lmao

�

𝓯𝓻𝓮𝓪𝓴onomist•10/2/24, 4:21 PM

It will get merged soon

jardonOP•10/2/24, 4:21 PM

I'm tired of rebasing

�

𝓯𝓻𝓮𝓪𝓴onomist•10/2/24, 4:21 PM

He can do it

Draft: feat: Add featured apps configura...

Similar Threads

Similar Threads

Similar Threads