which one is "more correct" in hono?

LLordSilver which one is "more correct" in hono?

H

I would go with

c.text

c.text

c.text

c.text

L

LordSilverOP•10/26/24, 2:44 PM

wow, i've just noticed taht some code that used to work previously now doesn't work anymore

L

LordSilverOP•10/26/24, 2:44 PM

this code, after updating to latest hono version doesn't work anymore, i get an empty object

L

LordSilverOP•10/26/24, 2:45 PM

i tried to copy this other code, but doesn't work

L

LordSilverOP•10/26/24, 2:45 PM

you get the object, but without the header set.

L

LordSilverOP•10/26/24, 2:45 PM

L

LordSilverOP•10/26/24, 2:45 PM

i probably missed some recent change

L

LordSilverOP•10/26/24, 2:48 PM

they should all work theoretically

LLordSilver this code, after updating to latest hono version doesn't work anymore, i get an ...

I

Isaac McFadyen•10/26/24, 2:49 PM

Is it actually a JSON object? You're telling Hono that it's JSON but then supplying your own content-type

I

Isaac McFadyen•10/26/24, 2:49 PM

It probably strips it.

I

Isaac McFadyen•10/26/24, 2:49 PM

Try newResponse as Leo said above

L

LordSilverOP•10/26/24, 2:51 PM

i'm not using c.json anymore tho

L

LordSilverOP•10/26/24, 2:53 PM

c.json used to work in the past

L

LordSilverOP•10/26/24, 2:53 PM

i updated hono and now i get a

{}

{}

response, i had to update the code

L

LordSilverOP•10/26/24, 3:03 PM

mmm ok, there's something wrong with

result.httpMetadata.contentType

result.httpMetadata.contentType

result.httpMetadata.contentType

result.httpMetadata.contentType. I think R2 doesn't do any file autodetection upon uploading

Original message was deleted

L

LordSilverOP•10/26/24, 4:10 PM

didn't know about this. i think it's more readable than returning a body. that feels wrong to me, even if you set the headers separately, i still read it as returning a body alone

A

Avi•10/26/24, 7:11 PM

hey, i'd like to be able to a job to run at an arbitrary time in the future - say 24 hours. i'd want this timing to be configurable in code, dynamically, via a worker (a DurableObject) like:

sendPushNotification(userId, Date.now() + 24 hours)

sendPushNotification(userId, Date.now() + 24 hours)

sendPushNotification(userId, Date.now() + 24 hours)

sendPushNotification(userId, Date.now() + 24 hours)

I'm wondering what might be the best approach to design this system:
1) write a row to a database, then have a cron (via worker

scheduled

scheduled

scheduled

scheduled) that runs every ~10 minutes to process anything that's "due". this seems the simplest.
2) use DO

alarm()

alarm()

alarm()

alarm() feature. this is theoretically simpler, but I don't see how I could use it for multiple users, since it's one alarm per DO.
3) use the new "workflows" feature...?

Original message was deleted

A

Avi•10/26/24, 7:16 PM

thanks for the input. wdym by "wake up at the next one"?

A

Avi•10/26/24, 7:19 PM

like every single notification would be a separate DO?
So that "notification DO" would have an API like:

POST /schedule?timestamp=some_timestamp&payload=abc

POST /schedule?timestamp=some_timestamp&payload=abc

POST /schedule?timestamp=some_timestamp&payload=abc

POST /schedule?timestamp=some_timestamp&payload=abc

storage.set('payload', abc)
alarm(some_timestamp)

storage.set('payload', abc)
alarm(some_timestamp)

storage.set('payload', abc)
alarm(some_timestamp)

storage.set('payload', abc)
alarm(some_timestamp)

A

Avi•10/26/24, 7:19 PM

something like that? if so, not sure why i'd need D1 for this (unless instead of DO transactional storage I used D1)

F

fry69•10/26/24, 7:19 PM

How about using the fancy new Workflows? They can sleep for an arbitrary time.

A

Avi•10/26/24, 7:19 PM

right that's what I was wondering about with 3)

A

Avi•10/26/24, 7:20 PM

seems a bit complex and new

F

fry69•10/26/24, 7:22 PM

So far all I have heard here is really complex, workflows seem very natural step-by-step execution compared.

A

Avi•10/26/24, 7:23 PM

hmm. i feel like the simplest is literally just one DB row per notification, and a single worker on a cron job that processes it periodically

F

fry69•10/26/24, 7:23 PM

One step can be sleep(Date.now() + 24 hours)

A

Avi•10/26/24, 7:23 PM

seems like workflows require at least 3 workers minimum

A

Avi•10/26/24, 7:24 PM

A

Avi•10/26/24, 7:24 PM

maybe i'm misunderstanding something but this feels quite heavy-handed

F

fry69•10/26/24, 7:24 PM

That is behind the scenes, you don't have to worry about that.

A

Avi•10/26/24, 7:25 PM

hmm. ok, i'll dig a bit deeper here then

A

Avi•10/26/24, 7:25 PM

i find cloudflare's blog posts announcing new features often blur the internal implementation details with the user-facing API in a way that makes it hard to understand exactly waht the DX is

A

Avi•10/26/24, 7:26 PM

as opposed to separate "here is the new thing!" and "here is how it works under the hood" blog posts. but that's besides the point.

AAvi i find cloudflare's blog posts announcing new features often blur the internal i...

F

fry69•10/26/24, 7:26 PM

I liked the two 6 min videos -> workflows

Ffry69 I liked the two 6 min videos -> https://discord.com/channels/595317990191398933/...

A

Avi•10/26/24, 7:27 PM

i hadn't seen this! looking into it now

AAvi i hadn't seen this! looking into it now

F

fry69•10/26/24, 7:29 PM

Also the guide is pretty straight forward IMHO -> https://developers.cloudflare.com/workflows/get-started/guide/

Cloudflare Docs

Guide | Cloudflare Workflows docs

Workflows allow you to build durable, multi-step applications using the Workers platform. A Workflow can automatically retry, persist state, run for hours or days, and coordinate between third-party APIs.

A

Avi•10/26/24, 7:30 PM

got it!

A

Avi•10/26/24, 7:45 PM

ok, from looking into it a bit more - it does seem like workflows would be a great tool here. but it's just a bit too unstable/immatre to trust at this point. it seems it only just barely works in

wrangler dev

wrangler dev

, there's no way to delete workflows, etc

D

DoggeSlapper•10/27/24, 4:26 PM

If I got folowing scheduled on wrangler what I should do set to 5min? Or that will always catch into the 5min case?

  scheduled(event: ScheduledEvent, env: Bindings, ctx: ExecutionContext) {
    switch (event.cron) {
      case "*/5 * * * *":
        break;
      case "*/10 * * * *":
        // Every ten minutes
        break;
      case "0 * * * *":
        // Every hour
        break;
      case "0 0 * * *":
        // Every day
        break;
    }
  },

  scheduled(event: ScheduledEvent, env: Bindings, ctx: ExecutionContext) {
    switch (event.cron) {
      case "*/5 * * * *":
        break;
      case "*/10 * * * *":
        // Every ten minutes
        break;
      case "0 * * * *":
        // Every hour
        break;
      case "0 0 * * *":
        // Every day
        break;
    }
  },

  scheduled(event: ScheduledEvent, env: Bindings, ctx: ExecutionContext) {
    switch (event.cron) {
      case "*/5 * * * *":
        break;
      case "*/10 * * * *":
        // Every ten minutes
        break;
      case "0 * * * *":
        // Every hour
        break;
      case "0 0 * * *":
        // Every day
        break;
    }
  },

  scheduled(event: ScheduledEvent, env: Bindings, ctx: ExecutionContext) {
    switch (event.cron) {
      case "*/5 * * * *":
        break;
      case "*/10 * * * *":
        // Every ten minutes
        break;
      case "0 * * * *":
        // Every hour
        break;
      case "0 0 * * *":
        // Every day
        break;
    }
  },

Original message was deleted

K

Kevin•10/27/24, 4:39 PM

Unless you are fine with loads of boilerplate, I'd recommend using a lightweight router of some sort (e.g Hono or itty). They just streamline the routing/matching logic so you can focus on your handlers instead of how to register/match them.

DDoggeSlapper If I got folowing scheduled on wrangler what I should do set to 5min? Or that wi...

D

DoggeSlapper•10/27/24, 4:42 PM

Answering my self should be an array as in https://developers.cloudflare.com/workers/configuration/cron-triggers/

Cloudflare Docs

Cron Triggers | Cloudflare Workers docs

Enable your Worker to be executed on a schedule.

K

kaelys.js•10/27/24, 7:55 PM

Is there a proper channel to ask questions about snippets?

Kkaelys.js Is there a proper channel to ask questions about snippets?

D

DaniFoldi•10/27/24, 10:53 PM

There's no dedicated channel, so if it's a code-related question, I think here or #workers-help is fine. If it's more of a ruleset engine question, maybe #general-help / #general-discussions is more suitable

G

gh0st.•10/27/24, 11:09 PM

Hey if I had a domain registered on another domain registrar and I wanted to switch to CloudFlare what would I have to do?

G

gh0st.•10/27/24, 11:11 PM

Also how do I check the plan I have on CloudFlare or change it and what it has?

Ggh0st.Hey if I had a domain registered on another domain registrar and I wanted to swi...

A

akashra•10/27/24, 11:34 PM

You want to transfer the domain to Cloudflare? Or you want to keep it with the other registrar and just point various resolved domains to Cloudflare?

Aakashra You want to transfer the domain to Cloudflare? Or you want to keep it with the ...

G

gh0st.•10/27/24, 11:35 PM

point various resolved domains?

A

akashra•10/27/24, 11:36 PM

do you just want a resolution of an address defined in a zone to ultimately be recognised and usable as an endpoint running on CF?

G

gh0st.•10/27/24, 11:37 PM

Sorry I'm a beginner and I understood nothing of what you just said

G

gh0st.•10/27/24, 11:37 PM

But I'm pretty sure I just would want to transfer the domain to CloudFlare

which one is "more correct" in hono?

Similar Threads