in most cases the worker is only hit if there's no asset match
in most cases the worker is only hit if there's no asset match
JSPA mode adds a few more conditions
J
Syea this is where the wording gets confusing
example.com > obviously index.html (routing works fine)
example.com/some/sub/page > no asset match and no worker route match? so it should also go back to index.html
talking about pressing refresh or directly navigating to the page with a URL
example.com > obviously index.html (routing works fine)
example.com/some/sub/page > no asset match and no worker route match? so it should also go back to index.html
talking about pressing refresh or directly navigating to the page with a URL
Jthe worker "route" will never be checked and then go back to assets, unless you're doing that in your own code. It'll check for exact match, handle spa behaviour if needed, and then fallback to your user worker as the final step
JI honestly couldn't tell you exactly what the logic is for how that works with SPA mode
Jwe're talking about 2 different questions/issues here though for sure. Your's is slightly different to what @matthewlsessions is observing, which is the weird
assets_navigation_prefers_asset_serving behaviour
GThat’s correct, yes. I’m working on some more comprehensive docs at the moment (sorry for the delay in getting docs published before this change went live), but you can expect them to be live early next week. In the meantime, as @James says, you can add the
assets_navigation_has_no_effect flag if you wish to opt out. For most people though, we expect this change to be a welcome one. In traditional SPA setups, this will reduce the number of billable requests that you see in your application, without affecting functionality.GThanks, as ever, for fielding questions, @James !
GDefinitely don’t dispute that it’s potentially confusing though! Hopefully updated docs help to clarify.
JYeah I think once people understand how it works, it might be welcomed, but for folks new to the platform or the web in general, it's very unintuitive. Expecting different responses when hitting a route in your browser vs
fetchwranglerI don't think anyone really expects to see a different response in their browser when they hit
/api/foo vs when they fetchYup, totally understand. And I think your idea of more comprehensive logging is absolutely a good one. If you’ve got specific suggestions here, I’m all ears. Otherwise, I’ll take a stab at something myself next week and see what we can do to make the request flows more obvious in
wrangler dev
JI think if there was a log that very clearly stated
GET /api/foo - Received Sec-Fetch-Mode: navigate, serving <> or words to that effect, it'd help a lot with the confusion.
I^ and would be immediately visible if users post their logs in here and we need to help them troubleshoot.
GLogic is:
- Check if request “exactly matches” an asset. If yes, serve.
- If no, but request is a navigation request, and new compat flag is enabled and
assets.not_found_handlingis something other than “none”, that fallback is served (index.html for SPA, 404.html for 404-page). - If not navigation request or flag is disabled, worker script is invoked if present. Since this is now happening after the fallback serving in typical SPA modes, an assets binding and final
env.ASSETS.fetch(request)will likely no longer be necessary in most applications. They can now just return 404s or whatever. - Finally, if the worker script either isn’t present or does
env.ASSETS.fetch(request), a response according toassets.not_found_handlingis returned.
GI’m on mobile right now, so can’t try to repro, but if something isn’t following that, I’m pretty sure it’s a legit bug.
G“Exactly matches” is in quotes to hand wave over HTML handling.
GAgain, this’ll all be documented more formally next week. Apologies for this rough first draft 
JThanks. When you're next available, taking a look at the example @Silvan posted in https://canary.discord.com/channels/595317990191398933/1358194995076796507/1358195325306802306 might help a bit. I think what's happening is technically expected, but not what I would expect intuitively. I couldn't tell you why the SPA behaviour isn't working for them at all on a compat date prior to April 1st - I must be missing something.
JIn the future, it might be preferrable to not enable things like this so quickly by default when the documentation/education/logs around it aren't complete yet 
Bnot sure where to post this but please...
- can we please allow upload .env directly for build variables ? it is annoying we have to upload one by one thorugh the ui ( regular env var seems like support pasting dotenv) - when using sveltekit we have to provide them for build .. and i think in pages, all env variables are also used as build variables
- is there an max limit for build variable for workers ? once my build var reach 50+ i got Initializing build environment... internal error occurred. Please retry your build. If this problem persists, contact Cloudflare support.
Stechnically it makes 100% sense else i dont get how this would even work
but this needs to be documented very clearly in 1 place else its very hard to find the connection between all these things
but this needs to be documented very clearly in 1 place else its very hard to find the connection between all these things
JIf I'm reading correctly, it looks like the
404.html traverses up to find one, but index.html doesn't in SPA mode, which might explain your weirdness @Silvan: https://github.com/cloudflare/workers-sdk/blob/d4c11710fd36286be8587379d659e19e91778777/packages/workers-shared/asset-worker/src/handler.ts#L867JI've not tested and haven't looked that closely at this code, but that looks like what it's doing
Zi reran npx wrangler types to generate a new worker-configuration.d.ts, and instead of doing this:
interface Env {
...
}
it did:
declare namespace Cloudflare {
interface Env {
...
}
}
interface Env extends Cloudflare.Env {}
and now my env doesn't work anywhere... (context.cloudflare.env doesn't have any of my types on it) Has anyone run into this or know how to fix it? (this is in a remix app, but I've updated to wrangler 4 and been using it fine for a bit...)
interface Env {
...
}
it did:
declare namespace Cloudflare {
interface Env {
...
}
}
interface Env extends Cloudflare.Env {}
and now my env doesn't work anywhere... (context.cloudflare.env doesn't have any of my types on it) Has anyone run into this or know how to fix it? (this is in a remix app, but I've updated to wrangler 4 and been using it fine for a bit...)
II'm having the exact problem. Spent an hour reading docs, forums, but didn't find any solution. Came here (discord) in hopes of fix, but seems you didn't get any help either. Not a good first impression for this tool..
KSame, getting this error on WSL2
VHi. I'm trying to escalate this internally. Can you please share replication steps?
VOr you're just running
wrangler devthanks. I'm passing this internally
KI rollback to 3.107.3 and it seems to work
PWhat about 4.0.0?
PAnd what about 3.108.0 @klouzo35 ?
KWith the 4.0.0 I have the error but not with 3.108.0
KAlso I tested with 3.114.4 and the error was there
JI can repro in my environment if you want to dig in, Samuel, just lemme know
J- `3.108.0` throws a more detailed error: ```✘ [ERROR] /home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd)/home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd:/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by/home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd)/home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd:/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by/home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd)/home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd:/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.35' not found (required by/home/cherry/.npm/_npx/a49ae4159d496e8f/node_modules/@cloudflare/workerd-linux-64/bin/workerd)```
J3.114.4 throws the same detailed error
J3.103.2 is the last version that works for me here. 3.105.0 is where it starts throwing.
JOh, yeah this is 20
Vthank youu
