Think it's good to go. Removed the SELinux hack and added the SecureBoot info to README Renamed the

Think it's good to go.
Removed the SELinux hack and added the SecureBoot info to README
Renamed the cosmic-base image to cosmic
Updated the secureboot password to match the rest of the org

antheas•8/8/24, 5:31 PM

@Kyle Gospo current /usr/etc files from 30 image

message.txt2.06KB

antheas•8/8/24, 5:31 PM

july 30 that is

antheas•8/8/24, 5:31 PM

wow thats quite a bit

antheas•8/8/24, 5:31 PM

you really put everything in there

fiftydinar•8/8/24, 5:31 PM

Ideally, when inspecting, /usr/etc//usr/etc/ should be empty, right

RRobert Think it's good to go. Removed the SELinux hack and added the SecureBoot info to...

j0rge•8/8/24, 5:32 PM

ack I'll ack and merge as soon as things turn green

antheas•8/8/24, 5:32 PM

i mean rn it just gets force merged to etc

j0rge•8/8/24, 5:32 PM

https://github.com/ublue-os/cosmic/pull/50 what am I doing with this?

antheas•8/8/24, 5:32 PM

and the polkit.d dir that is problematic gets permission quirked afterwards

antheas•8/8/24, 5:32 PM

so the polkits should still work

antheas•8/8/24, 5:33 PM

but yeah all those dirs will have their permissions reset, so if there is a dir in those that needs special handling like polkit.d it needs to be fixed up afterwards

Aantheas but yeah all those dirs will have their permissions reset, so if there is a dir ...

Kyle Gospo•8/8/24, 5:33 PM

should all be fixed in latest on bazz

Kyle Gospo•8/8/24, 5:34 PM

only remaining file in /usr/etc I'm aware of is the policy.json

KKyle Gospo should all be fixed in latest on bazz

antheas•8/8/24, 5:34 PM

stable?

Kyle Gospo•8/8/24, 5:34 PM

next build, yea

antheas•8/8/24, 5:34 PM

is it in testing?

Kyle Gospo•8/8/24, 5:34 PM

yes

antheas•8/8/24, 5:34 PM

ok let me do testing

Kyle Gospo•8/8/24, 5:34 PM

which is rebuilding now

Kyle Gospo•8/8/24, 5:34 PM

would re-run after that

antheas•8/8/24, 5:34 PM

you can also switch to 0.8.3 rechunk

Kyle Gospo•8/8/24, 5:34 PM

since that gets the changes to main too

antheas•8/8/24, 5:34 PM

which will show the tree

antheas•8/8/24, 5:34 PM

https://github.com/hhd-dev/rechunk/actions/runs/10306670670/job/28530248072

HikariKnight•8/8/24, 5:43 PM

will default configs still end up in

/usr/etc

/usr/etc

for the end user? might have some documentation i need to update if it isnt

HHikariKnight will default configs still end up in `/usr/etc` for the end user? might have som...

antheas•8/8/24, 5:44 PM

yes its the same as before

j0rge•8/8/24, 5:45 PM

@Robert (p5) ok final build and then I'll kick off the ISOs

antheas•8/8/24, 5:45 PM

there was an implicit merge between /etc and /usr/etc

HikariKnight•8/8/24, 5:45 PM

ok thats good at least

antheas•8/8/24, 5:45 PM

nothing changes fundamentally

HikariKnight•8/8/24, 5:45 PM

sorry i havent been on before now so i am out of the loop, being a gardener all day yesterday knocked me out

Jj0rge @Robert (p5) ok final build and then I'll kick off the ISOs

RobertOP•8/8/24, 5:47 PM

Thanks! Once this is done, I think Cosmic should be in pretty much it's final form, and I guess waiting around for upstream to fix things like the software rendering.
We don't want to add features to Cosmic since it's an unopinionated base image, and the ISOs work.

M2•8/8/24, 5:48 PM

yepp. Cosmic is basically a main image

j0rge•8/8/24, 5:48 PM

yeah, am I merging this selinux PR?

RobertOP•8/8/24, 5:48 PM

The docs one? I don't think there's a need now. SELinux works, and people shouldn't be daily driving it.
https://github.com/ublue-os/cosmic/pull/50

M2•8/8/24, 5:48 PM

The docs change is to say to keep SELinux enabled. Currently it says to disable it

MM2 The docs change is to say to keep SELinux enabled. Currently it says to disable ...

RobertOP•8/8/24, 5:49 PM

My PR removed that text

j0rge•8/8/24, 5:49 PM

oh we just don't mention it

j0rge•8/8/24, 5:49 PM

so I'll close the PR

j0rge•8/8/24, 5:50 PM

https://github.com/ublue-os/cosmic/pull/35 this can go?

RobertOP•8/8/24, 5:51 PM

Yeah, that was a bad idea from the start

fiftydinar•8/8/24, 5:55 PM

@Robert (p5) you forgot to update this part of README

fiftydinar•8/8/24, 5:55 PM

Dylan•8/8/24, 5:55 PM

I might need some help understanding this. The argument for NVIDIA_FLAVOR is making it to the buildah command.

buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 --label io.artifacthub.package.readme-url=https://raw.githubusercontent.com/ublue-os/akmods/main/README.md --label org.opencontainers.image.created=2024-08-08T15:37:49.669Z --label org.opencontainers.image.description=A caching layer for pre-built akmod RPMs --label org.opencontainers.image.licenses=Apache-2.0 --label org.opencontainers.image.revision=4bf4904792d88ddce5d03dbf59540e78fd4b7623 --label org.opencontainers.image.source=https://github.com/ublue-os/akmods --label org.opencontainers.image.title=akmods --label org.opencontainers.image.url=https://github.com/ublue-os/akmods --label org.opencontainers.image.version=6.9.12-200.fc40.x86_64.20240808.0 --label ostree.linux=6.9.12-200.fc40.x86_64 --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40 /home/runner/work/akmods/akmods

But in the container file even with ARG NVIDIA_FLAVOR, I am seeing it unset.

Dylan•8/8/24, 5:55 PM

I did

ARG NVIDIA_FLAVOR
ENV NVIDIA_FLAVOR=${NVIDIA_FLAVOR}
RUN DRIVER_TYPE=$([ "$NVIDIA_FLAVOR" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE

and it shows nf - dt kernel-open

Dylan•8/8/24, 5:55 PM

env shows NVIDIA_FLAVOR=

Dylan•8/8/24, 5:56 PM

Am I fundamentally misunderstanding how build arguments should work on a containerfile?

Dylan•8/8/24, 5:56 PM

I do see --build-arg NVIDIA_FLAVOR=nvidia-legacy in the initial command

Ffiftydinar @Robert (p5) you forgot to update this part of README

RobertOP•8/8/24, 5:56 PM

Ah, thanks. I'll do another README cleanup PR in a bit.

Dylan•8/8/24, 5:57 PM

I wonder if this is a bug in buildah

Think it's good to go. Removed the SELinux hack and added the SecureBoot info to README Renamed the

Similar Threads

Similar Threads

Similar Threads