will default configs still end up in `/usr/etc` for the end user? might have some documentation i ne

will default configs still end up in

/usr/etc

/usr/etc

/usr/etc

/usr/etc for the end user? might have some documentation i need to update if it isnt

HHikariKnight will default configs still end up in `/usr/etc` for the end user? might have som...

antheas•8/8/24, 5:44 PM

yes its the same as before

j0rge•8/8/24, 5:45 PM

@Robert (p5) ok final build and then I'll kick off the ISOs

antheas•8/8/24, 5:45 PM

there was an implicit merge between /etc and /usr/etc

HikariKnightOP•8/8/24, 5:45 PM

ok thats good at least

antheas•8/8/24, 5:45 PM

nothing changes fundamentally

HikariKnightOP•8/8/24, 5:45 PM

sorry i havent been on before now so i am out of the loop, being a gardener all day yesterday knocked me out

Jj0rge @Robert (p5) ok final build and then I'll kick off the ISOs

Robert•8/8/24, 5:47 PM

Thanks! Once this is done, I think Cosmic should be in pretty much it's final form, and I guess waiting around for upstream to fix things like the software rendering.
We don't want to add features to Cosmic since it's an unopinionated base image, and the ISOs work.

M2•8/8/24, 5:48 PM

yepp. Cosmic is basically a main image

j0rge•8/8/24, 5:48 PM

yeah, am I merging this selinux PR?

Robert•8/8/24, 5:48 PM

The docs one? I don't think there's a need now. SELinux works, and people shouldn't be daily driving it.
https://github.com/ublue-os/cosmic/pull/50

M2•8/8/24, 5:48 PM

The docs change is to say to keep SELinux enabled. Currently it says to disable it

MM2 The docs change is to say to keep SELinux enabled. Currently it says to disable ...

Robert•8/8/24, 5:49 PM

My PR removed that text

j0rge•8/8/24, 5:49 PM

oh we just don't mention it

j0rge•8/8/24, 5:49 PM

so I'll close the PR

j0rge•8/8/24, 5:50 PM

https://github.com/ublue-os/cosmic/pull/35 this can go?

Robert•8/8/24, 5:51 PM

Yeah, that was a bad idea from the start

fiftydinar•8/8/24, 5:55 PM

@Robert (p5) you forgot to update this part of README

fiftydinar•8/8/24, 5:55 PM

Dylan•8/8/24, 5:55 PM

I might need some help understanding this. The argument for NVIDIA_FLAVOR is making it to the buildah command.

buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 --label io.artifacthub.package.readme-url=https://raw.githubusercontent.com/ublue-os/akmods/main/README.md --label org.opencontainers.image.created=2024-08-08T15:37:49.669Z --label org.opencontainers.image.description=A caching layer for pre-built akmod RPMs --label org.opencontainers.image.licenses=Apache-2.0 --label org.opencontainers.image.revision=4bf4904792d88ddce5d03dbf59540e78fd4b7623 --label org.opencontainers.image.source=https://github.com/ublue-os/akmods --label org.opencontainers.image.title=akmods --label org.opencontainers.image.url=https://github.com/ublue-os/akmods --label org.opencontainers.image.version=6.9.12-200.fc40.x86_64.20240808.0 --label ostree.linux=6.9.12-200.fc40.x86_64 --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40 /home/runner/work/akmods/akmods

But in the container file even with ARG NVIDIA_FLAVOR, I am seeing it unset.

Dylan•8/8/24, 5:55 PM

I did

ARG NVIDIA_FLAVOR
ENV NVIDIA_FLAVOR=${NVIDIA_FLAVOR}
RUN DRIVER_TYPE=$([ "$NVIDIA_FLAVOR" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE

and it shows nf - dt kernel-open

Dylan•8/8/24, 5:55 PM

env shows NVIDIA_FLAVOR=

Dylan•8/8/24, 5:56 PM

Am I fundamentally misunderstanding how build arguments should work on a containerfile?

Dylan•8/8/24, 5:56 PM

I do see --build-arg NVIDIA_FLAVOR=nvidia-legacy in the initial command

Ffiftydinar @Robert (p5) you forgot to update this part of README

Robert•8/8/24, 5:56 PM

Ah, thanks. I'll do another README cleanup PR in a bit.

Dylan•8/8/24, 5:57 PM

I wonder if this is a bug in buildah

Dylan•8/8/24, 6:20 PM

... wow. I removed the labels and it worked. I think something in the github action to parse labels to command line args is breaking it

Dylan•8/8/24, 6:20 PM

❯ buildah bud -f Containerfile.nvidia --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40
...
[2/3] STEP 16/18: ARG NVIDIA_FLAVOR
[2/3] STEP 17/18: RUN DRIVER_TYPE=$([ "${NVIDIA_FLAVOR}" = "nvidia-legacy" ] && echo "kernel" || echo "kernel-open") && echo nf ${NVIDIA_FLAVOR} - dt $DRIVER_TYPE
nf nvidia-legacy - dt kernel

Dylan•8/8/24, 6:24 PM

or maybe it's a formatting issue w/ one of the labels breaking it. Maybe I'll try re-adding labels one at a time.

Noel•8/8/24, 6:26 PM

@j0rge Bluefin got a shout-out from Dan Walsh on the big screen.

j0rge•8/8/24, 6:26 PM

\o/

j0rge•8/8/24, 6:26 PM

what room are you in? I'll go find it

Noel•8/8/24, 6:27 PM

Red Hat room, you'll have to back up a few minutes!

j0rge•8/8/24, 6:27 PM

NNoel @j0rge Bluefin got a shout-out from Dan Walsh on the big screen.

Dylan•8/8/24, 6:27 PM

that's awesome

Noel•8/8/24, 6:27 PM

I was not expecting it lol

j0rge•8/8/24, 6:28 PM

oh this whole talk looks good, backing up

Noel•8/8/24, 6:28 PM

Yes! I recommend everyone watch this talk.

Noel•8/8/24, 6:28 PM

It's really well presented.

Noel•8/8/24, 6:28 PM

Dan Walsh is a legend.

Dylan•8/8/24, 6:29 PM

Working:

buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url='https://avatars.githubusercontent.com/u/1728152?s=200&v=4' --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40

Not working:

buildah bud -f Containerfile.nvidia --label io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 --build-arg BUILDER_IMAGE=quay.io/fedora/fedora --build-arg KERNEL_ORG=ublue-os --build-arg KERNEL_FLAVOR=main --build-arg FEDORA_MAJOR_VERSION=40 --build-arg RPMFUSION_MIRROR= --build-arg NVIDIA_FLAVOR=nvidia-legacy --build-arg DUAL_SIGN=true --format docker --tls-verify=true -t akmods-nvidia-open:pr-225-main-40

Might have to put values in quotes.